Repository navigation
feat(nmr): unify phase entry and axis semantics - #168
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use one Phase command for 1D, 2D and 3D spectra, with explicit targets, acquisition axes and processing scope.
Validation
cargo pr-check— passed. Regression coverage includes command routing, axis mapping, draft invalidation, project changes, cancellation, result installation and pivot invariance against the NMR processing engine.npm run buildindocs/— passed, generating 123 pages.git diff --check— passed.UI display logic
CommandId+describe) and are searchable in the command palette.disabled_reasonthat says how to unblock.docs/(English and zh-CN) for user-visible behavior.