Skip to content

feat(nmr): unify phase entry and axis semantics - #168

Merged
nmrtist merged 1 commit into
mainfrom
feat/unified-phase
Nov 4, 2026
Merged

nmrtist merged 1 commit into
mainfrom
feat/unified-phase

Conversation

@nmrtist

@nmrtist nmrtist commented Nov 4, 2026

Copy link
Copy Markdown
Owner

Summary

Use one Phase command for 1D, 2D and 3D spectra, with explicit targets, acquisition axes and processing scope.

  • Route standalone spectra to canvas phasing and 3D spectra to the whole-volume editor; remove duplicate entries and keep command gating consistent with the interaction target.
  • Label acquisition axes and display roles, and support ppm pivots with PH0 compensation that preserves the phase correction.
  • Keep drafts and background results tied to their spectrum and project. Invalidate stale drafts across undo, and distinguish applying, discarding, stopping and closing.
  • Update the English and Simplified Chinese guides.

Validation

  • cargo pr-check — passed. Regression coverage includes command routing, axis mapping, draft invalidation, project changes, cancellation, result installation and pivot invariance against the NMR processing engine.
  • npm run build in docs/ — passed, generating 123 pages.
  • Manual Windows GUI acceptance — passed.
  • git diff --check — passed.

UI display logic

  • New or changed actions go through the command catalog (CommandId + describe) and are searchable in the command palette.
  • Hiding happens only at Ribbon-group level (dataset kind or width budget); transient states disable with a disabled_reason that says how to unblock.
  • No layout changes from background events; panels are never auto-closed.
  • New panels or empty regions show an empty state with a next step.
  • Docs updated in docs/ (English and zh-CN) for user-visible behavior.

@nmrtist
nmrtist merged commit a4f015c into main Nov 4, 2026
11 checks passed
@nmrtist
nmrtist deleted the feat/unified-phase branch November 4, 2026 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant