Skip to content

feat(nmr): add interactive 3D phase previews - #170

Merged
nmrtist merged 1 commit into
mainfrom
feat/interactive-volume-phase
Nov 5, 2026
Merged

nmrtist merged 1 commit into
mainfrom
feat/interactive-volume-phase

Conversation

@nmrtist

@nmrtist nmrtist commented Nov 5, 2026

Copy link
Copy Markdown
Owner

Summary

Preview 3D NMR phase edits on the current plane before applying them to the entire spectrum.

  • Share PH0, PH1 and ppm pivot edits between canvas gestures and numeric controls, with previews computed by the NMR processing engine.
  • Preserve committed contour thresholds and companion layers; reject stale preview results and keep drafts separate from persisted data.
  • Make canvas phasing a consistent toggle, support direct 2D axis selection, and retain drafts when leaving the mode.
  • Update the English and Simplified Chinese guides.

Validation

  • cargo pr-check — passed, including numerical preview comparisons, pivot invariance, draft isolation, stale results and interaction tests.
  • npm run build in docs/ — passed, generating 123 pages.
  • Screenshot harness — completed; reviewed the 3D phase preview in light and dark themes.
  • git diff --cached --check — passed.

UI display logic

  • New or changed actions go through the command catalog (CommandId + describe) and are searchable in the command palette.
  • Hiding happens only at Ribbon-group level (dataset kind or width budget); transient states disable with a disabled_reason that says how to unblock.
  • No layout changes from background events; panels are never auto-closed.
  • New panels or empty regions show an empty state with a next step.
  • Docs updated in docs/ (English and zh-CN) for user-visible behavior.

@nmrtist
nmrtist merged commit dbf4d0a into main Nov 5, 2026
11 checks passed
@nmrtist
nmrtist deleted the feat/interactive-volume-phase branch November 5, 2026 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant