Skip to content

feat(protein): add scientific context for 3D spectra - #172

Merged
nmrtist merged 1 commit into
mainfrom
feat/protein-scientific-context
Nov 5, 2026
Merged

nmrtist merged 1 commit into
mainfrom
feat/protein-scientific-context

Conversation

@nmrtist

@nmrtist nmrtist commented Nov 5, 2026

Copy link
Copy Markdown
Owner

Summary

Record sample conditions and experiment metadata alongside protein assignments so 3D spectra carry explicit scientific context.

  • Persist reusable sample conditions and experiment types with acquisition-axis roles, validation and Undo/Redo.
  • Add a panel editor with optional JSON editing, stale-draft protection and recovery when the target spectrum is deleted.
  • Check initial structure scope and NOESY proton roles against recorded context and acquired nuclei.
  • Add persistence, validation and interaction regressions, and update the English and Simplified Chinese guides.

Validation

  • cargo pr-check — passed, including persistence, Undo/Redo, scope boundaries, draft conflicts and widget interaction tests. Reran with the Windows permissions required by ACL and discovery-lock tests.
  • npm run build in docs/ — passed, generating 123 pages.
  • git diff --cached --check — passed.

UI display logic

  • New controls are panel-local widget interactions, exempt from command catalog registration.
  • Transient conflicts disable saving with guidance on how to recover; no Ribbon visibility changes.
  • No layout changes from background events; panels are never auto-closed.
  • Empty editing states provide a next step to select or create sample conditions.
  • Docs updated in docs/ (English and zh-CN) for user-visible behavior.

@nmrtist
nmrtist merged commit 2e1cebd into main Nov 5, 2026
11 checks passed
@nmrtist
nmrtist deleted the feat/protein-scientific-context branch November 5, 2026 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant