Skip to content

feat(protein): add reviewable chemical-shift lists - #174

Merged
nmrtist merged 1 commit into
mainfrom
feat/protein-shift-review
Nov 5, 2026
Merged

nmrtist merged 1 commit into
mainfrom
feat/protein-shift-review

Conversation

@nmrtist

@nmrtist nmrtist commented Nov 5, 2026

Copy link
Copy Markdown
Owner

Summary

Turn manual peak assignments into traceable chemical-shift lists grouped by sample conditions, atom target and nucleus.

  • Preserve individual observations, partial assignments and OneOf/Shared semantics without averaging.
  • Add review controls with recognizable residue labels, uncertainty, notes and explicit selection or exclusion.
  • Persist reviews with Undo/Redo and project roundtrips; invalidate decisions and drafts when observation snapshots or sample conditions change.
  • Add regression coverage and update the English and Simplified Chinese guides.

Validation

  • cargo pr-check — passed in 164 seconds, including observation grouping, review validation, sample-condition invalidation, Undo/Redo, project roundtrips and residue labels.
  • npm run build in docs/ — passed, generating 123 pages.
  • git diff --cached --check — passed.

UI display logic

  • Review controls are panel-local widget interactions, exempt from command catalog registration.
  • Empty states and review errors provide guidance.
  • No layout changes from background events; panels are never auto-closed.
  • Docs updated in docs/ (English and zh-CN) for user-visible behavior.

@nmrtist
nmrtist merged commit 49f9def into main Nov 5, 2026
11 checks passed
@nmrtist
nmrtist deleted the feat/protein-shift-review branch November 5, 2026 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant