fix: exit Alpine build on unsupported architectures - #2602
Conversation
MikeMcC399
left a comment
There was a problem hiding this comment.
LGTM!
Hopefully it should never hit this line of code!
|
@tianon @LaurentGoderre @yosifkit I did see a few different patterns like https://github.com/docker-library/openjdk/blob/b05c83d6bd9ca39869729ac90a403edcd8d9efd2/27/bookworm/Dockerfile#L54 on some of the other official images. Is this change OK, or should it be following an upstream pattern (and the Debian images updated too) |
|
I would feel comfortable landing this PR, since it extends the same method to Alpine variants that has been in use for quite a while successfully on Debian variants (although I don't think it has ever triggered). The other example only looked marginally different, and in both cases they're using |
It seems fine to me. I think it was previously this fall through so that it could build on an architecture not in the case, but I think you no longer put architectures in the DOI |
Description
If one of the allowlisted architectures from the
version.jsonparsed list isn't found, exit the build like on the Debian images.Motivation and Context
Noticed that the default case on the Alpine behaved differently from the Debian version. Took the same message from the Debian template.
Testing Details
Example Output(if appropriate)
Types of changes
Checklist