Skip to content

util: fix formatting of functions returned from getters - #64839

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
gibson042:gh-64838-inspect-function-from-getter
Aug 22, 2026
Merged

util: fix formatting of functions returned from getters#64839
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
gibson042:gh-64838-inspect-function-from-getter

Conversation

@gibson042

Copy link
Copy Markdown
Contributor

Fixes: #64838

Fixes: nodejs#64838
Signed-off-by: Richard Gibson <richard.gibson@gmail.com>
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module. labels Jul 30, 2026
@codecov

codecov Bot commented Jul 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.18%. Comparing base (29d183d) to head (d23a740).
⚠️ Report is 397 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #64839      +/-   ##
==========================================
+ Coverage   90.15%   90.18%   +0.02%     
==========================================
  Files         746      746              
  Lines      242764   242760       -4     
  Branches    45741    45767      +26     
==========================================
+ Hits       218857   218921      +64     
+ Misses      15418    15324      -94     
- Partials     8489     8515      +26     
Files with missing lines Coverage Δ
lib/internal/util/inspect.js 96.93% <100.00%> (ø)

... and 45 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@avivkeller avivkeller left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from linting, LGTM

@avivkeller avivkeller added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Aug 1, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 1, 2026
@nodejs-github-bot

This comment was marked as resolved.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@trivikr trivikr added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 22, 2026
@nodejs-github-bot
nodejs-github-bot merged commit a48e33f into nodejs:main Aug 22, 2026
88 of 90 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in a48e33f

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

util.inspect fails to represent a function returned from a getter

4 participants