vm: allow global proxy reuse across contexts - #65477
Open
koal44 wants to merge 1 commit into
Open
Conversation
Signed-off-by: koal44 <random.var.ny@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cross-document navigation in a browsing context creates a new
Windowandrealmwhile preserving the identity of itsWindowProxy/globalThis. Modeling this behavior withnode:vmis currently not possible, as discussed in #855 and #31807.This PR adds a
reuseGlobalProxyoption tovm.createContext(). When supplied a global proxy produced withvm.constants.DONT_CONTEXTIFY, Node.js detaches it from the old context and attaches it to a new one.The implementation was inspired by Chromium’s approach: detaching the old context, then passing the preserved global proxy into the replacement context.
Conceptually: