Repository navigation
Conversation
Statement::Close() untracks itself, so the constructor should track itself too, like Session does, instead of relying on every caller. Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>
Replace the custom deleter structs and OnScopeLeave cleanups with DeleteFnPtr aliases, and pass session ownership to Session::Create. Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>
Route every exit through Settle(), which finalizes, settles the promise and deletes the job once. This also frees the job when building the progress object fails. Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>
Store the template on the environment like the other sqlite classes, so stores no longer get a fresh template and prototype each time. Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #66912 +/- ##
==========================================
+ Coverage 90.51% 90.58% +0.06%
==========================================
Files 797 797
Lines 278252 278487 +235
Branches 53472 53531 +59
==========================================
+ Hits 251868 252257 +389
+ Misses 16761 16584 -177
- Partials 9623 9646 +23
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ownership cleanups in
node_sqlite.cc:Statementconstructor instead of in each caller, matchingSession.DeleteFnPtrfor every SQLite handle and drop the custom deleter structs andOnScopeLeavecleanups.BackupJobthrough a singleSettle()so there is onedelete this. This also frees the job when building the progress object fails, which leaked before.SQLTagStoreconstructor template on the environment, so all tag stores share one prototype.