Repository navigation
Conversation
nodejs-github-bot
added
needs-ci
A TransformStream write that parks on backpressure was resumed from the read that lifted the backpressure, so transform(), the writes queued behind it, and flush() ran in the reader's async context instead of the writer's. Capture the async context frame when the write parks and restore it while the continuation runs, matching the context the spec's [[backpressureChangePromise]] reaction had. When async hooks are enabled, which includes the async_hooks-based AsyncLocalStorage used with --no-async-context-frame, the continuation is instead registered on a promise created at park time and resolved on unpark, as before. Fixes: nodejs#66906 Signed-off-by: Matteo Collina <hello@matteocollina.com>
mcollina
force-pushed
the
backport-66907-v26
branch
from
October 22, 2026 15:50
28fe6e1 to
c405372
Compare
mcollina
marked this pull request as ready for review
October 22, 2026 15:52
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v26.x-staging #66915 +/- ##
=================================================
+ Coverage 90.24% 90.75% +0.51%
=================================================
Files 729 775 +46
Lines 242760 273485 +30725
Branches 46044 52521 +6477
=================================================
+ Hits 219073 248210 +29137
- Misses 15133 16143 +1010
- Partials 8554 9132 +578
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #66907 (not landed on
mainyet, hence draft).v26.x still has the async_hooks-based
AsyncLocalStorage(--no-async-context-frame; removed onmainin #63641), whereAsyncContextFrameis a no-op. So on top of themainchange, when async hooks are enabled at park time (which includes the legacyAsyncLocalStorage) the continuation is registered on a promise created at park time and resolved on unpark, restoring the pre-#65625 promise-reaction context. It runs at the same microtask position as before. Otherwise the frame capture frommainis used, and the cheap path stays allocation-free.Adds
test-whatwg-transformstream-parked-write-async-context-legacy.js, which runs the same assertions under--no-async-context-frame.Verified locally on this branch:
whatwg/webstream tests, WPT streams, async-local-storage and async-hooks suites pass.
Alternative: #66914 reverts the regressing commits on v26.x instead. Only one of the two should land.
Refs: #66906
Refs: #66907
AI generated, reviewed by me