Repository navigation
Conversation
Accept both BoringSSL error codes for an untrusted leaf certificate. Add the --use-system-ca hint for X509_V_ERR_UNABLE_TO_GET_ISSUER_CERT_LOCALLY. Enable BoringSSL coverage for DH, X.509, cipher metadata and TLS tests. Use modp5 for the DH group setters test and SSL_get_peer_tmp_key for both SSL backends. Refs: https://boringssl-review.googlesource.com/c/boringssl/+/103849 Refs: electron/electron@b457e70 Signed-off-by: Filip Skokan <panva.ip@gmail.com> Assisted-by: Codex
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
Member
Author
|
@aduh95 this is needed prior to NixOS/nixpkgs@1c17f6e hitting the nixpkgs-unstable tools update. I've tested locally with it in place. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66921 +/- ##
=======================================
Coverage 90.57% 90.58%
=======================================
Files 797 797
Lines 278502 278494 -8
Branches 53540 53528 -12
=======================================
+ Hits 252247 252264 +17
+ Misses 16592 16571 -21
+ Partials 9663 9659 -4
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accept both BoringSSL error codes for an untrusted leaf certificate. Add the --use-system-ca hint for
X509_V_ERR_UNABLE_TO_GET_ISSUER_CERT_LOCALLY.
Enable BoringSSL coverage for DH, X.509, cipher metadata and TLS tests. Use modp5 for the DH group setters test and SSL_get_peer_tmp_key for both SSL backends.
Related:
b457e70(#55110)