Repository navigation
[v24.x backport] fs: stop recursive mkdir from retrying ENOENT forever - #66927
Open
junaidkhan80121 wants to merge 1 commit into
Open
junaidkhan80121 wants to merge 1 commit into
junaidkhan80121 wants to merge 1 commit into
Conversation
Backport of nodejs#66340 to v24.x-staging. Also covers nested procfs paths from nodejs#66890. Fixes: nodejs#66268 Fixes: nodejs#66890
nodejs-github-bot
added
c++
Contributor
|
Welcome to Node.js, and thank you for your first contribution! Before review, please take a moment to read:
Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ShouldRetryENOENT) so recursivefs.mkdirstops retrying forever whenmkdirreturnsENOENTeven though the parent exists (e.g. under/proc)./proc/.../deepercase from fs.mkdir(path, { recursive: true }) never returns when an intermediate mkdir fails with ENOENT although its parent exists (e.g. under /proc) #66890.Test plan
python3 tools/test.py parallel/test-fs-mkdir-recursive-enoent parallel/test-heapdump-fs-mkdir-recursivefs.mkdirSync('/proc/nope/deeper', { recursive: true })→ENOENT(no hang)Refs: #66340
Fixes: #66890