Repository navigation
build: include system ICU headers with -isystem - #66928
Closed
khemssharma wants to merge 1 commit into
Closed
khemssharma wants to merge 1 commit into
khemssharma wants to merge 1 commit into
Conversation
nodejs-github-bot
added
build
Contributor
|
Welcome to Node.js, and thank you for your first contribution! Before review, please take a moment to read:
Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal. |
With --error-on-warn now enabled in test-shared.yml, warnings emitted from third-party ICU headers (e.g. clang's -Wunnecessary-virtual-specifier in unicode/uniset.h) were turned into errors on x86_64-darwin. Pass system ICU include dirs via -isystem so only Node.js-specific warnings fail the build. Signed-off-by: Ayush Sharma <ayushsharma3310@gmail.com>
khemssharma
force-pushed
the
fix-system-icu-isystem
branch
from
October 22, 2026 12:43
2d37ae9 to
a4f609b
Compare
Contributor
|
This defeats the purpose of 796a83a, and I don’t think it’s worth doing. The current state of things works fine without any warnings on all platforms but x64 macOS, which is experimental only |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With --error-on-warn now enabled in test-shared.yml, warnings emitted from third-party ICU headers (e.g. clang's
-Wunnecessary-virtual-specifier in unicode/uniset.h) were turned into errors on x86_64-darwin. Pass system ICU include dirs via -isystem so only Node.js-specific warnings fail the build.