Repository navigation
module: fix require(esm) error annotation with tracing subscriber - #66930
Open
CodingRule wants to merge 1 commit into
Open
CodingRule wants to merge 1 commit into
CodingRule wants to merge 1 commit into
Conversation
reconstructErrorStack() took the first stack frame as the caller, but with a module.require tracing subscriber that frame is TracingChannel.traceSync, so the arrow pointed at a nonexistent line of the parent file. Pick the first frame that belongs to the parent. Fixes: nodejs#55350
Collaborator
|
Review requested:
|
Contributor
|
Welcome to Node.js, and thank you for your first contribution! Before review, please take a moment to read:
Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reconstructErrorStack()takes the first stack frame as therequire()caller. When amodule.requiretracing subscriber exists, that frame isTracingChannel.traceSync, so the arrow points at a nonexistent line of the parent file:Pick the first frame that belongs to the parent file instead. Works for nested callers too (the first parent frame is the
require()call site).Adds a test case with a
tracing:module.require:startsubscriber; it fails on currentmainand passes with this change.Fixes: #55350
AI disclosure
This change was made with help from an AI coding assistant (Claude Mythos 5.1). I reviewed the diff and the reasoning behind it myself.
What was verified:
tracing:module.require:startsubscriber: the arrow points attest.cjs:568withundefined.reconstructErrorStack()from both the original and patchedloader.jsagainst real stacks captured from the nightly, in four shapes: plain, with subscriber, nested callers, nested with subscriber. The patched version annotates therequire()call site in all four. The original fails in both subscriber cases.tools/eslinton both files with--max-warnings=0.Not run locally: the test against a binary built from this branch (no ClangCL toolchain on my machine). I'll follow up on review feedback myself.