Skip to content

permission: prefer --permission over audit mode - #67036

Open
RafaelGSS wants to merge 2 commits into
nodejs:mainfrom
RafaelGSS:prefer-permission-over-audit-mode
Open

RafaelGSS wants to merge 2 commits into
nodejs:mainfrom
RafaelGSS:prefer-permission-over-audit-mode

Conversation

@RafaelGSS

Copy link
Copy Markdown
Member

permission: prefer --permission over audit mode

When both --permission and --permission-audit are set, run in enforce
mode as documented, instead of only reporting denials and keeping the
environment variables.

When both --permission and --permission-audit are set, run in enforce
mode as documented, instead of only reporting denials and keeping the
environment variables.

Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/security-wg
  • @nodejs/startup

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. permission Issues and PRs related to the Permission Model. labels Oct 26, 2026
@codecov

codecov Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.68%. Comparing base (91c4436) to head (f7519c0).
⚠️ Report is 106 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/process/permission.js 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #67036      +/-   ##
==========================================
- Coverage   92.93%   90.68%   -2.26%     
==========================================
  Files         428      797     +369     
  Lines      195236   278793   +83557     
  Branches    30176    53609   +23433     
==========================================
+ Hits       181442   252810   +71368     
- Misses      13467    16347    +2880     
- Partials      327     9636    +9309     
Files with missing lines Coverage Δ
src/env.cc 84.45% <100.00%> (ø)
src/node.cc 79.84% <100.00%> (ø)
lib/internal/process/permission.js 90.62% <0.00%> (-1.93%) ⬇️

... and 509 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
@RafaelGSS

Copy link
Copy Markdown
Member Author

PTAL @nodejs/security-wg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. permission Issues and PRs related to the Permission Model.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants