Repository navigation
v8: support X509Certificate serialization - #67083
Merged
Merged
Conversation
v8.serialize() currently rejects X509Certificate objects. Add a host object encoding containing the certificate's DER snapshot, including its issuerCertificate chain, and reconstruct fresh X509Certificate objects in v8.deserialize(). Read the stored snapshot rather than the cached raw Buffer, which can be modified by callers. Decode each certificate independently without imposing issuer relationships on the serialized sequence. Assisted-by: Codex Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #67083 +/- ##
==========================================
- Coverage 90.65% 90.65% -0.01%
==========================================
Files 797 797
Lines 278593 278740 +147
Branches 53570 53610 +40
==========================================
+ Hits 252561 252686 +125
- Misses 16377 16383 +6
- Partials 9655 9671 +16
🚀 New features to boost your workflow:
|
panva
added
request-ci
anonrig
approved these changes
Nov 3, 2026
panva
added
author ready
github-actions
Bot
removed
the
request-ci
Collaborator
pimterry
approved these changes
Nov 3, 2026
| if (typeIndex === kX509CertificateHostObject) { | ||
| const count = this.readUint32(); | ||
| if (!hasOpenSSL || count === 0) { | ||
| throw new ERR_INVALID_STATE('Invalid serialized X509Certificate'); |
Member
There was a problem hiding this comment.
Nit: in the !hasOpenSSL case this error message is wrong. The cert is valid (probably) we just can't read it.
panva
added
the
commit-queue
Collaborator
|
Landed in d36e9ba |
nodejs-github-bot
removed
the
commit-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v8.serialize()currently rejectsX509Certificateobjects. Add a host object encoding containing the certificate's DER snapshot, including itsissuerCertificatechain, and reconstruct freshX509Certificateobjects inv8.deserialize().Read the stored snapshot rather than the cached
rawBuffer, which can be modified by callers. Decode each certificate independently without imposing issuer relationships on the serialized sequence.This is PR 3 out of 4 in an X.509 series addressing #48730 and #51169. (it can land independently of PR 2 https://redirect.github.com/nodejs/node/pull/67082)