Repository navigation
build: set V8_DISABLE_PRESERVE_MOST - #67093
Open
joyeecheung wants to merge 2 commits into
Open
joyeecheung wants to merge 2 commits into
joyeecheung wants to merge 2 commits into
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
build
Collaborator
joyeecheung
marked this pull request as ready for review
October 29, 2026 11:31
Member
Author
|
（triggering GHA for testing, not ready for review) |
Original commit message:
Add V8_DISABLE_PRESERVE_MOST for embedders to opt out of preserve_most
preserve_most changes the calling convention, which clang
encodes in the mangled name (e.g. "U" instead of "A" for cdecl in the
Microsoft C++ ABI). A consumer whose toolchain does not support
the attribute would reference a differently mangled symbol.
This patch adds a V8_DISABLE_PRESERVE_MOST to disable it, so that
it's possible to link to V8 using different toolchains, as long
as the value of it is set consistently.
Refs: nodejs#55784
Change-Id: I67b49e739942d4026ac060be35bb39ec22256cbd
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8532546
Commit-Queue: Joyee Cheung <joyee@igalia.com>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#111381}
Refs: v8/v8@c389861
joyeecheung
force-pushed
the
fix-perserve-most
branch
from
October 31, 2026 02:29
aad6a6b to
b5bcd54
Compare
Member
Author
|
https://chromium-review.googlesource.com/c/v8/v8/+/8532546 has landed. I backported it to replace the old floating patch with the new approach. This is now ready for review @nodejs/build @nodejs/v8-update |
joyeecheung
changed the title
legendecas
reviewed
Oct 31, 2026
Member
Author
I think that helps partially, yes, although for those consumers there can still be a gap depending on whether they include node.h consistently in all translation units or the order in which they include these headers... |
legendecas
approved these changes
Oct 31, 2026
legendecas
added
the
request-ci
Member
|
agree that these addons need more than |
github-actions
Bot
removed
the
request-ci
Collaborator
Collaborator
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/8532546
This replaces an old floating patch from #55784 to set the preserve_most attribute more consistently for build Node.js and addons consuming common.gypi. We use the explicit macro instead of toolchain detection so that it stays consistent across toolchains.