Repository navigation
perf_hooks: copy shared data before importing histograms - #67249
adityareddy-dev wants to merge 1 commit into
Conversation
|
Welcome to Node.js, and thank you for your first contribution! Before review, please take a moment to read:
Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal. Caution AgentScan found account activity patterns that may be consistent with automation. This is a heuristic, not proof that this pull request was opened by an agent or violates policy. AI-assisted contributions are permitted, but automated tooling must not open pull requests without advance approval, and contributors must personally understand, test, verify, and take responsibility for every submitted change. See the AgentScan analysis, AI use policy, and automation policy for additional context. |
Copy SharedArrayBuffer-backed input before parsing its CBOR data so concurrent worker writes cannot change the bytes during parsing. Fixes: nodejs#67152 Signed-off-by: Aditya Reddy <82123567+adityareddy-dev@users.noreply.github.com>
d7a5c02 to
52b15ac
Compare
|
The recommendations in: advise you should tackle only one issue at a time and that you should not open any new PRs until your first PR has been approved. You have multiple unapproved PRs open at this time. Until the first PR has been approved and has landed in the Waiting until the first PR has landed ensures that you as a contributor have experienced the complete process from PR submission to successful landing. After this has been completed, any new PRs or new commits to an existing PR are treated to rules for regular Contributors. GitHub Actions CI workflows are then run automatically without intervention by a team member. |
|
Thanks Mike, that makes sense. Closing this one for now and keeping #67243 open until it lands. |
importHistogram()reads the input several times while parsing CBOR. Copy SharedArrayBuffer-backed input first so concurrent worker writes cannot change the bytes during parsing, following the existing approach inBuffer.toString().Fixes: #67152