Skip to content

build: enable pie on linux #67386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
legendecas wants to merge 1 commit into
base: main
Choose a base branch
from
+23 −1
Open

build: enable pie on linux #67386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions common.gypi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -699,6 +699,23 @@
'cflags': [ '-fPIC' ],
'ldflags': [ '-fPIC' ],
}],
# Link executables as PIE so that ASLR randomizes the executable
# image too. Every object in a PIE must be built with `-fPIC` or
# `-fPIE`. PIE flags should not apply to shared library objects,
# like addons. `--fully-static` uses `-static-pie`, see configure.py.
[ 'OS=="linux" and configuring_node', {
'target_conditions': [
['_type=="executable"', {
'ldflags': [ '-pie' ],
}],
],
'conditions': [
# Use `-fPIE` unless the condition above uses `-fPIC`.
[ 'node_shared!="true" and node_enable_v8debughelper!="true"', {
'cflags': [ '-fPIE' ],
}],
],
}],
],
}],
[ 'OS in "aix os400"', {
Expand Down
7 changes: 6 additions & 1 deletion configure.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2472,7 +2472,12 @@ def configure_static(o):
return

if options.fully_static:
o['libraries'] += ['-static']
if flavor == 'linux':
# `-static` drops the `-pie` from common.gypi, e.g. clang:
# https://github.com/llvm/llvm-project/blob/68b03cf380e61c86aa59f94a10e8ce2d4c10cbb0/clang/lib/Driver/ToolChains/Gnu.cpp#L351-L366
o['libraries'] += ['-static-pie']
else:
o['libraries'] += ['-static']
elif options.partly_static:
o['libraries'] += ['-static-libgcc', '-static-libstdc++']
if options.enable_asan:
Expand Down
Loading