Skip to content

chore(demo): run the demo in UiKit's demo platform shell - #77

Merged
HecFranco merged 1 commit into
mainfrom
chore/demo-platform-shell
Nov 21, 2026
Merged

HecFranco merged 1 commit into
mainfrom
chore/demo-platform-shell

Conversation

@HecFranco

Copy link
Copy Markdown
Contributor

Moves the demo onto UiKit's shared demo platform shell (UiKit ^2.60), per the demo rollout brief (batch 3). Demo and demo docs only; no bundle code, no release.

Checklist

  • base.html.twig extends @NowoUiKit/demo_platform/layout.html.twig and declares nowo_ui_demo_platform (bundle, home, repository, nav with sections and test ids)
  • nowo_ui_kit.yaml: css_framework: custom, base_stylesheet: true, layouts.admin/guest -> base.html.twig
  • ui-kit-bundle: ^2.60 in the demo composer.json, demo lock updated
  • Old header / masthead / nav / theme markup deleted
  • No demo stylesheet, <style>, style="" or foreign stylesheet link; nowo-ui-demo-style-lint = 0 findings
  • No CDN script or stylesheet in the demo (the dev HotReloadBundle CDN scripts are switched off in the demo config: client_mode: visibility, idiomorph: false)
  • Page header with title, subtitle and actions on every demo page
  • Tables, forms, lists and details in _section.html.twig cards
  • Empty states via state; flashes under the page header
  • One primary button per view
  • e2e selectors updated (demo-platform), test ids kept; demo-platform.spec.ts rules check at 1440 and 390 px (touch), axe light/dark, phone drawer keyboard pass
  • Worker mode (kernel reset off): two requests in a row, current nav item follows each request
  • README screenshots regenerated without the toolbar
  • Repo CI (pending)

Results

  • Style lint: nowo-ui-demo-style-lint . = 0 finding(s).
  • Demo e2e (Playwright 1.65.1): 20 passed, including demo-platform.spec.ts (rules = [] at 1440 and 390 px touch, axe 0 serious/critical light and dark, drawer keyboard pass). The existing demo.spec.ts flaky-by-design entry test now waits for its own entry (the shell's flash region starts a session, so seeded entries carry a cookie too).
  • Shots tool (axe, rules): home and admin list clean on the shell.
  • Before/after screenshots: .uic-work/demo-b3/shots/HttpLog/{before,after}/.

Bundle-owned findings (not fixed here)

  • Admin list: the filter form built in NowoHttpLogExtension sets the framework classes form-control / form-select (rules check framework-class:*); allow-listed in demo-platform.spec.ts for that page only.
  • Admin entry page, phone width: axe scrollable-region-focusable (serious) on the request/response header tables (.nowo-ui-table-wrap without tabindex).

UiKit gaps

None.

@github-actions

Copy link
Copy Markdown

@coderabbitai review

@HecFranco
HecFranco marked this pull request as ready for review November 21, 2026 01:46
@HecFranco
HecFranco merged commit 2c12d91 into main Nov 21, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant