Repository navigation
chore(demo): run the demo in UiKit's demo platform shell - #77
Merged
Merged
Conversation
|
@coderabbitai review |
HecFranco
marked this pull request as ready for review
November 21, 2026 01:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the demo onto UiKit's shared demo platform shell (UiKit ^2.60), per the demo rollout brief (batch 3). Demo and demo docs only; no bundle code, no release.
Checklist
base.html.twigextends@NowoUiKit/demo_platform/layout.html.twigand declaresnowo_ui_demo_platform(bundle, home, repository, nav with sections and test ids)nowo_ui_kit.yaml:css_framework: custom,base_stylesheet: true,layouts.admin/guest->base.html.twigui-kit-bundle: ^2.60in the democomposer.json, demo lock updated<style>,style=""or foreign stylesheet link;nowo-ui-demo-style-lint= 0 findingsclient_mode: visibility,idiomorph: false)_section.html.twigcardsstate; flashes under the page headerdemo-platform), test ids kept;demo-platform.spec.tsrules check at 1440 and 390 px (touch), axe light/dark, phone drawer keyboard passResults
nowo-ui-demo-style-lint .= 0 finding(s).demo-platform.spec.ts(rules = [] at 1440 and 390 px touch, axe 0 serious/critical light and dark, drawer keyboard pass). The existingdemo.spec.tsflaky-by-design entry test now waits for its own entry (the shell's flash region starts a session, so seeded entries carry a cookie too)..uic-work/demo-b3/shots/HttpLog/{before,after}/.Bundle-owned findings (not fixed here)
NowoHttpLogExtensionsets the framework classesform-control/form-select(rules checkframework-class:*); allow-listed indemo-platform.spec.tsfor that page only.scrollable-region-focusable(serious) on the request/response header tables (.nowo-ui-table-wrapwithout tabindex).UiKit gaps
None.