Repository navigation
feat: UiKit filter bar, split / page_actions header and named Any options - #80
Merged
Merged
Conversation
…ions (Beacon UX review) Opt-in web_ui.header_actions (toolbar|split|page_actions) and web_ui.filter_actions (scaffold|filter_bar); named empty options for the method, body type and channel selects; client IP placeholder; translations in all locales. Defaults keep the 1.24 output. Requires nowo-tech/ui-kit-bundle ^2.27.
…anslatableMessage The header actions stay page.header.actions (a host with the UiKit compact header takes them into its top bar); the bundle renders no menu of its own. The choice placeholders are TranslatableMessage in the bundle domain, tested in en and es.
…ssFinals DG\BypassFinals re-registers its file:// stream wrapper around every filesystem call, and each stream_wrapper_register() leaves a "stream factory" resource that PHP frees only at shutdown. A debug kernel touches files on every request (config cache checks, route template map), so each request added 2 resources under the test bootstrap; after ~128k resources from the whole suite the resource list doubled (+5.24 MB in one request) inside the measured window of DddHostKernelTest (6161336 > 4194304 on DBAL 4). The 1.25 tests only shifted the count past 2^17; main has the same per-request resources and the same bundle memory profile. The memory-flat loops of DddHostKernelTest, ApiChannelKernelTest and WorkerModeKeptAliveKernelTest now restore the native wrapper after one warm-up request of each kind (classes stay loaded through BypassFinals) and enable it again afterwards. ApiChannelKernelTest also collects cycles before both measurements, like the other tests, so GC timing no longer decides the result. With the fix the resource count stays flat over the loop and the Ddd delta is 0.82 MB (main: 0.92 MB).
|
@coderabbitai review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opt-in header_actions / filter_actions, named Any options, translations. Defaults unchanged.