Repository navigation
feat(ui): Cancel first, then the primary in the path and redirect forms (UX-017) - #59
Merged
Merged
Conversation
…ms (UX-017) The new / edit path and redirect forms get the house order (Cancel first, then the primary on the right) from the UiKit form scaffold. Requires nowo-tech/ui-kit-bundle ^2.66; the page contract tests check the order.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Beacon UX review B7, UX-017: the new / edit path page (and the redirect forms) now put Cancel first, then the primary on the right, matching the UiKit dialogs. The import dialog already used this order.
composer.json:nowo-tech/ui-kit-bundlegoes from ^2.2 to ^2.66, so the order is guaranteed.formActionsOrderChecked().testPathAndRedirectFormsPutCancelFirstasserts[cancel, primary].Blocked until UiKit 2.66.0 is tagged
This PR raises the
nowo-tech/ui-kit-bundlefloor to ^2.66, which needs nowo-tech/UiKitBundle#139 to be tagged. Until then, CI cannot resolve the dependency and will fail.composer.lockhas not been refreshed yet: runcomposer update nowo-tech/ui-kit-bundleonce the tag exists and push that lock refresh to this branch.Rules checked
search "form buttons order", thenretrieve "forms,accessibility"; skill-version 2026_11_10-47b4c80e):type="button"and the primary is the submit button (forms §1).form_actionsslot.Tests
Run against the UiKit PR branch (path repository, ui-kit 2.66.0):
🤖 Generated with Claude Code