Skip to content

feat(ui): Cancel first, then the primary in the path and redirect forms (UX-017) - #59

Merged
HecFranco merged 2 commits into
mainfrom
feat/form-actions-order
Nov 22, 2026
Merged

HecFranco merged 2 commits into
mainfrom
feat/form-actions-order

Conversation

@HecFranco

Copy link
Copy Markdown
Contributor

Summary

Beacon UX review B7, UX-017: the new / edit path page (and the redirect forms) now put Cancel first, then the primary on the right, matching the UiKit dialogs. The import dialog already used this order.

  • No template change. The forms extend the UiKit form scaffold, which renders Cancel first from UiKit 2.66.
  • composer.json: nowo-tech/ui-kit-bundle goes from ^2.2 to ^2.66, so the order is guaranteed.
  • Both page contract tests (en, de) opt in to formActionsOrderChecked().
  • New test testPathAndRedirectFormsPutCancelFirst asserts [cancel, primary].
  • CHANGELOG and UPGRADING are updated.

Blocked until UiKit 2.66.0 is tagged

This PR raises the nowo-tech/ui-kit-bundle floor to ^2.66, which needs nowo-tech/UiKitBundle#139 to be tagged. Until then, CI cannot resolve the dependency and will fail. composer.lock has not been refreshed yet: run composer update nowo-tech/ui-kit-bundle once the tag exists and push that lock refresh to this branch.

Rules checked

  • Chrome Modern Web Guidance (search "form buttons order", then retrieve "forms,accessibility"; skill-version 2026_11_10-47b4c80e):
    • DOM order = Tab order, with no CSS reordering (forms §1, accessibility §5 / WCAG 2.4.3).
    • Secondary buttons are type="button" and the primary is the submit button (forms §1).
    • Previous comes before Next/submit (forms §11).
  • REQ-TWIG-005: no raw form controls. Buttons come from the form scaffold, UiKit partials, or the existing form_actions slot.
  • Translations: no new keys; the existing labels are reused.
  • FrankenPHP worker mode (kernel reset false): templates and tests only, no services or state.

Tests

Run against the UiKit PR branch (path repository, ui-kit 2.66.0):

  • PHPUnit: 664 tests, 4141 assertions, OK.
  • Line coverage: 100%.
  • php-cs-fixer: OK. PHPStan: OK.

🤖 Generated with Claude Code

…ms (UX-017)

The new / edit path and redirect forms get the house order (Cancel first, then
the primary on the right) from the UiKit form scaffold. Requires
nowo-tech/ui-kit-bundle ^2.66; the page contract tests check the order.
@HecFranco
HecFranco merged commit 5c63b67 into main Nov 22, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant