Repository navigation
test(ui): path and redirect forms follow UiKit's configured form actions order - #60
Merged
Merged
Conversation
…ons order UiKit 2.66.1 restores theme.form_actions_order primary_first as the default (owner decision 2026-11-22). The path and redirect forms get their row from the UiKit form scaffold; the test now checks them against the stub theme's configured order instead of a hard-coded Cancel first and passes on UiKit 2.66.0 and 2.66.1. The import dialog keeps Cancel first; the constraint stays ^2.66.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to UiKit 2.66.1 (nowo-tech/UiKitBundle#140; owner decision 2026-11-22:
theme.form_actions_orderdefaults toprimary_firstagain,cancel_firstis opt-in).cancel_first. The import dialog keeps Cancel first.testPathAndRedirectFormsFollowTheConfiguredOrder(wastestPathAndRedirectFormsPutCancelFirst) checks both forms against the stub theme's configured order (Theme::fromConfig('none', StubHost::theme())->formActionsOrder()), not a hard-coded Cancel first. The opt-in contract rule (English and German tests) follows the configured order on UiKit 2.66.1.nowo-tech/ui-kit-bundle: ^2.66(no test needs 2.66.1 API). The lock is not touched yet; it moves to 2.66.1 once it is tagged.form_actions_order: cancel_firstfor Cancel-first forms).Tests
PHPUnit runs green on UiKit 2.66.0 (locked) and on the UiKit 2.66.1 branch (52f29ec,
src/copied over vendor). Both runs: 664 tests, 4141 assertions. php-cs-fixer and PHPStan are clean.🤖 Generated with Claude Code