Skip to content

test(ui): path and redirect forms follow UiKit's configured form actions order - #60

Merged
HecFranco merged 1 commit into
mainfrom
fix/form-actions-configured-order
Nov 22, 2026
Merged

HecFranco merged 1 commit into
mainfrom
fix/form-actions-configured-order

Conversation

@HecFranco

Copy link
Copy Markdown
Contributor

Summary

Follow-up to UiKit 2.66.1 (nowo-tech/UiKitBundle#140; owner decision 2026-11-22: theme.form_actions_order defaults to primary_first again, cancel_first is opt-in).

  • The path and redirect forms (new/edit) get their row from the UiKit form scaffold, so no template change is needed. With UiKit 2.66.1 they put the primary first again unless the host sets cancel_first. The import dialog keeps Cancel first.
  • Tests: testPathAndRedirectFormsFollowTheConfiguredOrder (was testPathAndRedirectFormsPutCancelFirst) checks both forms against the stub theme's configured order (Theme::fromConfig('none', StubHost::theme())->formActionsOrder()), not a hard-coded Cancel first. The opt-in contract rule (English and German tests) follows the configured order on UiKit 2.66.1.
  • Constraint stays nowo-tech/ui-kit-bundle: ^2.66 (no test needs 2.66.1 API). The lock is not touched yet; it moves to 2.66.1 once it is tagged.
  • Docs: CHANGELOG (Unreleased → Changed), UPGRADING (set form_actions_order: cancel_first for Cancel-first forms).

Tests

PHPUnit runs green on UiKit 2.66.0 (locked) and on the UiKit 2.66.1 branch (52f29ec, src/ copied over vendor). Both runs: 664 tests, 4141 assertions. php-cs-fixer and PHPStan are clean.

🤖 Generated with Claude Code

…ons order

UiKit 2.66.1 restores theme.form_actions_order primary_first as the default
(owner decision 2026-11-22). The path and redirect forms get their row from the
UiKit form scaffold; the test now checks them against the stub theme's
configured order instead of a hard-coded Cancel first and passes on UiKit 2.66.0
and 2.66.1. The import dialog keeps Cancel first; the constraint stays ^2.66.
@HecFranco
HecFranco merged commit 22931ad into main Nov 22, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant