Repository navigation
Ruler and render fixes - #411
Merged
Merged
Conversation
dariormt
marked this pull request as ready for review
October 30, 2026 16:27
dariormt
enabled auto-merge
October 30, 2026 16:28
# Conflicts: # editor/Editors/PaletteViewModel.cs
Member
|
fix the conflicts bro |
There was a problem hiding this comment.
🟡 Changes recommended
Three moderate active issues remain: palette copying drops newly added detail fields, the Max emissive control is placed in the wrong row, and the renderer does not enforce the required texture-array format before binding.
3 open issues
Review effort: Lite
Member
|
also this doenst pass clang tidy dario |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.