Repository navigation
Update to Numpy > 2.0.0 and adding a pyproject.toml file for easier installation - #1212
Open
DARKMOONlite wants to merge 2 commits into
Open
DARKMOONlite wants to merge 2 commits into
DARKMOONlite wants to merge 2 commits into
Conversation
Added instructions for local installation of the devkit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found an overflow bug when running this package locally with numpy 2.0.0
Fixed it, just by casting directly to a
uint16as older version of numpy would automatically promote the type from anp.uint8to anp.uint16I have also run ruff, to check for any obvious namespace changes. and tried adding
np._set_promotion_state("weak_and_warn")to all existing tests to detect if there were any other random type promotions, but didn't find anyThis is not intended as a complete fix, as I have not checked the NuImages code,
Just leaving this here for anyone who really wants to use NuScenes with Numpy 2.