rofl: Move offer access policy to on-chain offer metadata - #711
Merged
Conversation
✅ Deploy Preview for oasisprotocol-cli canceled.
|
anzoman
force-pushed
the
anzoman/feature/rofl-offer-access-policy
branch
from
August 5, 2026 14:09
fb07310 to
a2c32dd
Compare
anzoman
marked this pull request as ready for review
August 11, 2026 08:09
matevz
approved these changes
Aug 25, 2026
matevz
left a comment
matevz
left a comment
Member
There was a problem hiding this comment.
Some nits. Otherwise I tested it and works as expected. The internal Testnet provider offer was successfully updated with the private flag and a list of allowed creators: https://explorer.oasis.io/testnet/sapphire/tx/5ccce8efb883667563892ee2eb445f7d80030b5d2c9ef0aec8e2255e0ec3967b
anzoman
force-pushed
the
anzoman/feature/rofl-offer-access-policy
branch
from
August 25, 2026 15:16
b3a4c80 to
4dd9480
Compare
Adds the `allowed_creators`, `allowed_artifacts` and `private` offer fields to the provider manifest. They are stored on-chain as the `net.oasis.scheduler.offer.*` metadata keys read by the ROFL Scheduler, so the access policy can now be changed with `rofl provider update-offers` instead of editing the node config and restarting the machine. Account names from the wallet and the address book are resolved to addresses, artifact kinds and hashes are validated up front and list entries are sorted and deduplicated so that reordering them in the manifest does not produce a spurious offer update.
Offers marked as private in their on-chain metadata are now omitted from `rofl provider list --show-offers`, `rofl provider show` and `rofl deploy --show-offers`. The new `--all` (`-a`) flag includes them again and private offers are marked as such when listed. Automatic offer selection in `rofl deploy` skips private offers, but an offer explicitly requested via `--offer` is still resolved so that whitelisted users can rent one.
Documents the `allowed_creators`, `allowed_artifacts` and `private` offer fields, the `--all` flag of the offer listings and extends the example provider manifest with an offer reserved for the provider's own team.
Moves `ShowOfferSummary` from `cmd/rofl/provider` to `cmd/rofl/common` next to the offer filtering, inlines `PublicOffers` into `FilterOffers` and renames the file to `provider.go`. Offer summaries now also list the accounts allowed to rent a machine from the offer, read from the on-chain metadata via the new `OfferAllowedCreators` helper.
anzoman
force-pushed
the
anzoman/feature/rofl-offer-access-policy
branch
from
August 25, 2026 15:23
4dd9480 to
42784c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds CLI support for the on-chain ROFL offer access policy introduced in oasisprotocol/oasis-sdk#2485. Implements oasisprotocol/oasis-sdk#2475 (CLI part).
Previously
allowed_creatorsandallowed_artifactslived in the ROFL node's localconfig.yml, so changing them meant editing the config and restarting the machine. They are now part of the offer metadata on-chain, and this PR exposes them as first-class fields of the provider manifest:Applying them is a plain
oasis rofl provider update-offers; the scheduler picks the new policy up on the next round.Docs counterpart for the node config side: oasisprotocol/docs#1788.