docs(devx): re-aim two stale comments in cross-package-test-inputs.mjs - #14807
Merged
Merged
Conversation
`scripts/cross-package-test-inputs.mjs`'s `@objectstack/spec` declaration block carried two comments PR #14557 made stale: - the `.claude/skills/spec-property-retirement/SKILL.md` entry said the retirement pin (`retired-key-migrate-sentence.test.ts`) judges "the ONE governed markdown file" — after #14557 the pin judges that file PLUS every `skills/**/*.md`. "One file, not `.claude/**`" was still literally true about the `.claude` entry while reading as an exhaustive scope claim about the test's population, so the sentence needed re-aiming, not a bumped count: it now names the two-corpus structure and points at the `skills/**` entry below for the second corpus. - the `skills/**` entry named `scripts/export-list.test.ts` as its only holder. `retired-key-migrate-sentence.test.ts` reads the same root (`PUBLISHED_SKILLS_ROOT`, `:102`) as its second corpus — "plus every `.md` file under `skills/`" (`:92`), emitted as `skills:`-prefixed entries (`:484-485`). The comment now names both holders. Comments only: every glob is unchanged, `check:cross-package-test-inputs` was already green on #14557's head, and it stays green here. Fixes #14560 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV
baozhoutao
marked this pull request as ready for review
September 3, 2026 04:55
baozhoutao
enabled auto-merge
September 3, 2026 04:55
Contributor
Contributor
Contributor
This was referenced Sep 3, 2026
Contributor
baozhoutao
deleted the
claude/issue-14560-cross-package-inputs-comments
branch
September 3, 2026 08:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14560
What was stale
scripts/cross-package-test-inputs.mjs's@objectstack/specdeclaration block carries two comments aboutpackages/spec/src/shared/retired-key-migrate-sentence.test.tsthat PR #14557 made stale (both drifts confirmed onorigin/mainat triage — see #14560 comment 5514093260):.claude/skills/spec-property-retirement/SKILL.mdentry (:147-150) said the retirement pin judges "the ONE governed markdown file … One file, not.claude/**." After test(spec): discover the migrate-sentence markdown corpus instead of naming one file #14557 the test also reads everyskills/**/*.md. "One file, not.claude/**" stayed literally true about the.claudeentry while reading as an exhaustive scope claim about the test's whole population — so per the triage ruling it couldn't be repaired by bumping a count; the sentence needed re-aiming to name the two-corpus structure.skills/**entry (:152-165, now:152-171) namedscripts/export-list.test.tsas its only holder.retired-key-migrate-sentence.test.tsreads the same root too.Test line refs backing the new comment text
packages/spec/src/shared/retired-key-migrate-sentence.test.ts::92— "plus every.mdfile underskills/" (doc comment on the corpus).:96—RETIREMENT_SKILL_MDresolves the.claudeentry's file.:102—PUBLISHED_SKILLS_ROOTresolvesskills/.:484-485— walksPUBLISHED_SKILLS_ROOTand emitsskills:-prefixed entries.What changed
Comments only — byte-neutral to behaviour. No glob changed, no declaration re-scoped, no other comment in the file touched (
:124and:382's own "One file, not …" sentences are untouched, correct, and out of scope).#13859/#14557are not reopened.Verification
pnpm check:cross-package-test-inputs(--self-test+ normal run): 117/117 self-test cases pass;OK: 25 package(s) read outside themselves, all declared, and turbo.json hashes every declared glob.— run both before and after mergingorigin/mainforward (fc648a256e→e6ac0c6fd5, fast-forward, no conflicts).node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --commands scripts/cross-package-test-inputs.mjsderived 15 local gate families (scripts/** surface, no changeset-triggered families apply — this PR carriesskip-changeset).check-ci-filter-parity,check-cross-package-test-inputs,check-self-test-wired,check-shard-attestation,check-whole-set-label-write,check:agent-test-spelling,check:bash32-floor,check:cli-command-ids,check:cross-package-test-inputs,check:entry-guard,check:parse-guard,check:pnpm-filter-targets,check:ratchet-remedy-authority,check:watch-hint-literal);check-test-completeness.mjsis NOT-MEASURED locally (it grades a savedturbo run testlog CI tees in —PREREQUISITE NOT MET, exit 3, per its own guidance; not a red).node scripts/pm/dispatch-gates.mjs --ran ran.list scripts/cross-package-test-inputs.mjsreconciled:15 derived, 14 run, 1 NOT-MEASURED, 0 UNRUN.node scripts/check-nul-bytes.mjs: OK, no raw control bytes introduced.Head commit at the time of this PR:
e431207aa4.skip-changeset:
scripts/**only, publishes nothing from any released package.🤖 Generated with Claude Code
https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV
Generated by Claude Code
Generated by Claude Code