Skip to content

fix: wrong function name in getCStringLength assertion message - #1713

Open
hilbert149 wants to merge 1 commit into
open-source-parsers:masterfrom
hilbert149:master
Open

fix: wrong function name in getCStringLength assertion message#1713
hilbert149 wants to merge 1 commit into
open-source-parsers:masterfrom
hilbert149:master

Conversation

@hilbert149

Copy link
Copy Markdown

fix: wrong function name in getCStringLength assertion message

@greptile-apps

greptile-apps Bot commented Sep 3, 2026

Copy link
Copy Markdown

Greptile Summary

Corrects the assertion diagnostic in Value::getCStringLength() so it names the function that raised the assertion.

  • Replaces the incorrect Json::Value::asCString() reference with Json::Value::getCStringLength().
  • Does not alter control flow, data handling, or public API behavior.

Confidence Score: 5/5

The PR appears safe to merge because it only corrects an assertion message without changing runtime logic.

The changed string accurately identifies the function containing the assertion, while the assertion condition and all subsequent behavior remain unchanged.

Important Files Changed

Filename Overview
src/lib_json/json_value.cpp The assertion text now accurately identifies getCStringLength(); no functional issue was found.

Reviews (1): Last reviewed commit: "fix: wrong function name in getCStringLe..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant