[SDK] Fix not reporting failures from MultiSpanProcessor/MultiLogRecordProcessor flush/shutdown - #4472
Open
denizariyan wants to merge 2 commits into
Open
Conversation
denizariyan
force-pushed
the
fix/not-reporting-multiprocessor-fail
branch
from
August 23, 2026 21:40
3161d5e to
868816a
Compare
denizariyan
marked this pull request as ready for review
August 23, 2026 21:43
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4472 +/- ##
==========================================
+ Coverage 83.09% 83.13% +0.04%
==========================================
Files 519 519
Lines 20253 20256 +3
==========================================
+ Hits 16827 16837 +10
+ Misses 3426 3419 -7
🚀 New features to boost your workflow:
|
…rdProcessor flush/shutdown
denizariyan
force-pushed
the
fix/not-reporting-multiprocessor-fail
branch
from
August 24, 2026 05:12
868816a to
7c5a260
Compare
dbarker
approved these changes
Aug 25, 2026
dbarker
left a comment
Member
There was a problem hiding this comment.
Thanks for the fix! Appreciate the test cleanup also.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4471
Changes
MultiSpanProcessor::ForceFlush,MultiSpanProcessor::InternalShutdownandMultiLogRecordProcessor::InternalShutdownwalk their children accumulating abool resultthat is initialised totrueand then combined with|=, so no child can ever move it offtrue.|=accumulations withif (!child) { result = false; }. If statement results in same instructions (i.e., no added branching) and is more readable and harder to get wrong.TracerContext/LoggerContextwrap the processor vector in aMulti*unconditionally, so this was returning a meaninglesstrueeven for users who configured a single processor.MultiSpanProcessorhad no test file anywhere in the tree andMultiLogRecordProcessor's only coverage was threeEnabled-related tests living insidesimple_log_record_processor_test.cc. I addedmulti_span_processor_test.ccandmulti_log_record_processor_test.cc, and moved those three existing tests into the latter so eachMulti*component is tested from a file named after it. The moved tests are unchanged apart from the suite name and dropping the now-redundantMultiLogRecordProcessorprefix from their names.For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes