feat(config): wire top-level attribute_limits into per-signal providers by ocelotl · Pull Request #5365 · open-telemetry/opentelemetry-python

ocelotl · 2026-06-26T21:15:47Z

Summary

Reads config.attribute_limits in configure_sdk() and passes it as a global fallback to create_tracer_provider() and create_logger_provider()
Per-signal limits (tracer_provider.limits / logger_provider.limits) always take precedence; absent fields fall back to the global value, then to OTel spec defaults
Adds log_record_limits parameter to LoggerProvider, threads it through Logger down to each ReadWriteLogRecord — mirroring how SpanLimits flows through TracerProvider

Test plan

tests/_configuration/test_sdk.py — global limits passed to per-signal factories
tests/_configuration/test_tracer_provider.py — per-signal override, global fallback, spec defaults
tests/_configuration/test_logger_provider.py — same coverage for logs; verifies limits are applied (not just warned about)
tests/logs/ — no regressions in existing log SDK tests

Copilot

Pull request overview

This PR extends the OpenTelemetry SDK declarative configuration path to support top-level attribute_limits as a global fallback for traces and logs, and adds programmatic log_record_limits support to LoggerProvider so log attribute limits can be configured consistently with SpanLimits.

Changes:

Thread config.attribute_limits through configure_sdk() into create_tracer_provider() / create_logger_provider() as a fallback when per-signal limits are absent.
Implement log-record limits creation in declarative config and pass the resulting log_record_limits into LoggerProvider, propagating to Logger and ReadWriteLogRecord.
Update/expand configuration tests and add a changelog entry.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
opentelemetry-sdk/src/opentelemetry/sdk/_configuration/_sdk.py	Plumbs top-level `attribute_limits` into per-signal configurators.
opentelemetry-sdk/src/opentelemetry/sdk/_configuration/_tracer_provider.py	Adds global fallback handling for span attribute limits in declarative config.
opentelemetry-sdk/src/opentelemetry/sdk/_configuration/_logger_provider.py	Adds log-record limits handling and wires limits into `LoggerProvider` construction.
opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/init.py	Threads `log_record_limits` from provider → logger → emitted log records.
opentelemetry-sdk/tests/_configuration/test_sdk.py	Updates expectations for updated configurator call signatures.
opentelemetry-sdk/tests/_configuration/test_tracer_provider.py	Adds tests covering global fallback semantics for traces.
opentelemetry-sdk/tests/_configuration/test_logger_provider.py	Updates tests to validate log-record limits are applied (not just warned/ignored).
opentelemetry-sdk/src/opentelemetry/sdk/trace/export/init.py	Minor formatting-only change to console exporter default formatter.
.changelog/5365.added	Documents the new config wiring and `LoggerProvider` limits support.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

xrmx · 2026-07-13T08:10:43Z

This needs a rebase after declarative config move

rads-1996

Need to rebase but otherwise LGTM.

aabmass

Wasn't super clear to me, is there any behavior change for users who are not using declarative config?

aabmass · 2026-08-03T21:18:37Z

    default values and from user provided arguments.

-    All limit arguments must be either a non-negative integer or ``None``.
+    All limit arguments must be either a non-negative integer, ``None`` or ``LogRecordLimits.UNSET``.


Is it part of the spec, and specifically the -1 value? I'm wondering if it's valid to set -1 in the declarative config yaml.

It's also different from the _ENV_VALUE_UNSET constant

-1 never appears in the YAML. The config schema constrains these fields to minimum: 0 or null, so null/omitted means "no limit" and the config layer turns that into the internal -1. It's an in-process sentinel, not a user value. Schema refs:

https://github.com/open-telemetry/opentelemetry-configuration/blob/52c265e8a59fbf25348be7dfd2cb5c432801358d/schema/opentelemetry_configuration.yaml#L69-L81
https://github.com/open-telemetry/opentelemetry-configuration/blob/52c265e8a59fbf25348be7dfd2cb5c432801358d/schema/logger_provider.yaml#L108-L127

It's also not new. I'm mirroring the existing SpanLimits.UNSET = -1 and its _from_env_if_absent guard:

opentelemetry-python/opentelemetry-sdk/src/opentelemetry/sdk/trace/__init__.py

Line 648 in 7bccdfc

UNSET = -1

opentelemetry-python/opentelemetry-sdk/src/opentelemetry/sdk/trace/__init__.py

Lines 727 to 732 in 7bccdfc

def _from_env_if_absent(

cls, value: int | None, env_var: str, default: int | None = None

) -> int | None:

if value == cls.UNSET:

return None

It differs from _ENV_VALUE_UNSET = "" because that guards the raw env-var string, while -1 guards the parsed int arg. Both already coexist in SpanLimits:

opentelemetry-python/opentelemetry-sdk/src/opentelemetry/sdk/trace/__init__.py

Line 87 in 7bccdfc

_ENV_VALUE_UNSET = ""

ocelotl · 2026-08-07T15:18:15Z

Wasn't super clear to me, is there any behavior change for users who are not using declarative config?

Nope, no behavior change

ReadWriteLogRecord.limits already defaults to LogRecordLimits() via field(default_factory=LogRecordLimits), so every log record was already being constructed with the default limits (128
attribute count, no length limit, env vars read):

This PR just threads an explicit log_record_limits through LoggerProvider -> Logger -> _from_api_log_record. Both LoggerProvider and Logger fall back to log_record_limits or
LogRecordLimits(), so when nobody sets it (the programmatic, non-config path) they get the exact same default they got before.

The only observable difference: the OTEL_* env-based limits are now read once at LoggerProvider construction instead of once per log record. Same values in practice, and arguably more
consistent, unless something mutates the env vars mid-process between records, which isn't a supported pattern.

opentelemetry-pr-dashboard · 2026-08-14T16:52:17Z

Pull request dashboard status

Waiting on reviewers · refreshed 2026-08-22 22:16 UTC

Review the latest changes.

Status above doesn't look right?

Just replied or pushed? Anything around or after the refresh time above may not be picked up yet — give it a few minutes.
Anything look wrong? Report it with what you expected; it helps us improve the dashboard.

ocelotl · 2026-08-22T21:51:24Z

This needs a rebase after declarative config move

done

ocelotl · 2026-08-22T21:51:39Z

Need to rebase but otherwise LGTM.

done

Parses config.attribute_limits in configure_sdk() and passes it as a global fallback to create_tracer_provider() and create_logger_provider(). Per-signal limits (tracer_provider.limits / logger_provider.limits) always take precedence; absent fields fall back to the global value, then to OTel spec defaults. For logs, adds log_record_limits to the LoggerProvider constructor, threads it through Logger, and applies it when constructing each ReadWriteLogRecord — mirroring how SpanLimits flows through TracerProvider.

…dk.py Co-authored-by: Aaron Abbott <aaronabbott@google.com>

ocelotl · 2026-08-22T21:52:11Z

/dashboard route:reviewers

opentelemetry-pr-dashboard · 2026-08-22T21:53:26Z

@ocelotl, this pull request was routed to reviewers.

ocelotl added a commit to ocelotl/opentelemetry-python that referenced this pull request Jun 26, 2026

chore: add changelog fragment for open-telemetry#5365

9e6b9b0

ocelotl marked this pull request as ready for review June 26, 2026 21:28

ocelotl requested a review from a team as a code owner June 26, 2026 21:28

otelbot-python Bot added this to Python PR digest Jun 26, 2026

herin049 approved these changes Jun 30, 2026

View reviewed changes

Comment thread opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/__init__.py

Comment thread opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/__init__.py

Comment thread opentelemetry-configuration/src/opentelemetry/configuration/_logger_provider.py Outdated

herin049 requested a review from Copilot June 30, 2026 01:25

Copilot started reviewing on behalf of herin049 June 30, 2026 01:25 View session

Copilot AI reviewed Jun 30, 2026

View reviewed changes

xrmx moved this to Approved PRs that need fixes in Python PR digest Jul 13, 2026

ocelotl force-pushed the diego/config-attribute-limits branch 2 times, most recently from 9f37481 to 5a0a1d0 Compare July 20, 2026 15:41

rads-1996 approved these changes Jul 29, 2026

View reviewed changes

github-project-automation Bot moved this from Approved PRs that need fixes to Approved PRs in Python PR digest Jul 29, 2026

ocelotl force-pushed the diego/config-attribute-limits branch from 5a0a1d0 to a1c69ca Compare July 30, 2026 21:11

aabmass reviewed Aug 3, 2026

View reviewed changes

aabmass moved this from Approved PRs to Approved PRs that need fixes in Python PR digest Aug 3, 2026

ocelotl force-pushed the diego/config-attribute-limits branch from a1c69ca to 8c0e64e Compare August 6, 2026 22:15

ocelotl force-pushed the diego/config-attribute-limits branch 2 times, most recently from 7b70474 to f0ef10d Compare August 7, 2026 16:07

opentelemetry-pr-dashboard Bot mentioned this pull request Aug 14, 2026

Pull Request Dashboard #5550

Open

This comment has been minimized.

Sign in to view

ocelotl and others added 4 commits August 22, 2026 16:51

Fix limits

227d879

Fix limits

0f9e389

Update opentelemetry-configuration/src/opentelemetry/configuration/_s…

cef2d13

…dk.py Co-authored-by: Aaron Abbott <aaronabbott@google.com>

Fix lint: remove unused import and apply ruff format

252abd5

ocelotl force-pushed the diego/config-attribute-limits branch from f0ef10d to 252abd5 Compare August 22, 2026 21:51

	def _from_env_if_absent(
	cls, value: int \| None, env_var: str, default: int \| None = None
	) -> int \| None:
	if value == cls.UNSET:
	return None

Uh oh!

Conversation

ocelotl commented Jun 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

xrmx commented Jul 13, 2026

Uh oh!

rads-1996 left a comment

Choose a reason for hiding this comment

Uh oh!

aabmass left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aabmass Aug 3, 2026

Choose a reason for hiding this comment

Uh oh!

ocelotl Aug 7, 2026

Choose a reason for hiding this comment

Uh oh!

ocelotl commented Aug 7, 2026

Uh oh!

opentelemetry-pr-dashboard Bot commented Aug 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull request dashboard status

Uh oh!

This comment has been minimized.

ocelotl commented Aug 22, 2026

Uh oh!

ocelotl commented Aug 22, 2026

Uh oh!

ocelotl commented Aug 22, 2026

Uh oh!

opentelemetry-pr-dashboard Bot commented Aug 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ocelotl commented Jun 26, 2026 •

edited

Loading

opentelemetry-pr-dashboard Bot commented Aug 14, 2026 •

edited

Loading