opentelemetry-sdk: don't read other resource attributes when building default service.name - #5547
Open
xrmx wants to merge 2 commits into
Open
Conversation
… default service.name Always use sys.executable if available instead.
Pull request dashboard statusWaiting on the author · refreshed 2026-08-21 18:55 UTC Respond to 1 review item (e.g. link a commit, explain why not, ask a follow-up):
Status above doesn't look right?
|
pmcollins
approved these changes
Aug 21, 2026
pmcollins
left a comment
Member
There was a problem hiding this comment.
LGTM. Not sure if the changelog should try to call this out as a potentially breaking change because it does seem unlikely.
| @@ -0,0 +1 @@ | |||
| `opentelemetry-sdk`: don't read eventually set `process.executable.name` resource attribute when building default `service.name` | |||
Member
There was a problem hiding this comment.
Suggested change
| `opentelemetry-sdk`: don't read eventually set `process.executable.name` resource attribute when building default `service.name` | |
| `opentelemetry-sdk`: don't read `process.executable.name` resource attribute when building default `service.name` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Always use sys.executable if available instead of looking at an eventual
process.executable.nameset in resource attributes.Fixes #5544
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Checklist: