Skip to content

chore: Testable build - #7

Closed
nickevansuk wants to merge 4 commits into
mainfrom
ci/testable-build
Closed

nickevansuk wants to merge 4 commits into
mainfrom
ci/testable-build

Conversation

@nickevansuk

Copy link
Copy Markdown
Contributor

No description provided.

howaskew added a commit that referenced this pull request Oct 21, 2026
Allow the Update Data Model workflow to be called from other
repositories with a models-lib or data-models ref. When called this way
it generates the TypeScript models, builds and tests them, and does not
create a pull request. models-lib pull requests can then check that the
generated TypeScript compiles and passes the example tests.

Replaces #7, which predates the GitHub App token change: it used an
expression in a reusable workflow `uses:` (not allowed), and checked out
the calling repository instead of models-ts when called from elsewhere.
This version runs the tests in the same job, so no nested workflow or
artifact is needed.

Also:
- name the models-ts repository in its checkout
- run the models-ts tests (tsc and mocha) before creating a pull request
- Node 18.17.1, actions/checkout v4, actions/setup-node v4
- peter-evans/create-pull-request v7 (v4 fails after updating an
  existing pull request: "Cannot read properties of undefined")
@howaskew

Copy link
Copy Markdown
Contributor

Superseded by #12, which makes the Update Data Model workflow callable from other repositories, rebased on the GitHub App token changes. It also runs the tests in the same job instead of a nested workflow and names the models-ts repository in its checkout so it works when called from models-lib.

@howaskew howaskew closed this Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants