Repository navigation
chore: Testable build - #7
Closed
nickevansuk wants to merge 4 commits into
Closed
nickevansuk wants to merge 4 commits into
nickevansuk wants to merge 4 commits into
Conversation
howaskew
added a commit
that referenced
this pull request
Oct 21, 2026
Allow the Update Data Model workflow to be called from other repositories with a models-lib or data-models ref. When called this way it generates the TypeScript models, builds and tests them, and does not create a pull request. models-lib pull requests can then check that the generated TypeScript compiles and passes the example tests. Replaces #7, which predates the GitHub App token change: it used an expression in a reusable workflow `uses:` (not allowed), and checked out the calling repository instead of models-ts when called from elsewhere. This version runs the tests in the same job, so no nested workflow or artifact is needed. Also: - name the models-ts repository in its checkout - run the models-ts tests (tsc and mocha) before creating a pull request - Node 18.17.1, actions/checkout v4, actions/setup-node v4 - peter-evans/create-pull-request v7 (v4 fails after updating an existing pull request: "Cannot read properties of undefined")
This was referenced Oct 22, 2026
Contributor
|
Superseded by #12, which makes the Update Data Model workflow callable from other repositories, rebased on the GitHub App token changes. It also runs the tests in the same job instead of a nested workflow and names the models-ts repository in its checkout so it works when called from models-lib. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.