Repository navigation
chore(api): clarify project API key update requirements - #1244
Merged
Merged
Conversation
Contributor
Castiron custom codeEvaluated main: Trusted main policy: ✅ No new custom-code files detected. 97 mixed files remain; 0 existing customizations changed. Compared 97 existing customizations unchanged
57 more in the full report. A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 39480740277 --repo openai/openai-java \
--name castiron-custom-code-39480740277-1 --dir /tmp/castiron-custom-code-39480740277-1
git apply --stat /tmp/castiron-custom-code-39480740277-1/custom-code.patch
cat /tmp/castiron-custom-code-39480740277-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 199cf8169a49dc72bcf7fd869817917383e5ca77 78a81f9fc3bf81c19d81db88cec95080e0bbbe7e
python3 scripts/castiron/custom_code_report.py report \
--base 199cf8169a49dc72bcf7fd869817917383e5ca77 \
--head 78a81f9fc3bf81c19d81db88cec95080e0bbbe7e --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-78a81f9fc3bf
cat /tmp/castiron-custom-code-78a81f9fc3bf/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
dpiet-oai
approved these changes
Oct 20, 2026
markstuart-oai
approved these changes
Oct 20, 2026
markstuart-oai
left a comment
markstuart-oai
left a comment
Contributor
There was a problem hiding this comment.
Reviewed c0fe004. No blocking findings.
The schema requires scopes, an expiry, or both without changing existing value constraints. The reporter annotation and bound test callback preserve behavior. The WebSocket test builds its fixture before the timed cleanup scenario and retains its deadlines and assertions. Published runtime code is unchanged.
All current hosted checks are successful or skipped. I reviewed source and hosted CI; I did not run tests or builds locally.
jbeckwith-oai
marked this pull request as ready for review
October 20, 2026 15:42
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
Castiron-Internal-PR: openai/openai-java-internal#295 Castiron-Source-SHA: c153e0f442f3d4f69dfb80c2627fa8f51616b681 Castiron-Public-Base-SHA: 199cf81
jbeckwith-oai
force-pushed
the
castiron/promotions/pr-295
branch
from
October 20, 2026 19:06
c0fe004 to
78a81f9
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 20, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Oct 20, 2026
Merged
jaredosgood
pushed a commit
to jaredosgood/openai-java
that referenced
this pull request
Oct 22, 2026
Automated Release PR --- ## [4.87.1](openai/openai-java@v4.87.0...v4.87.1) (2026-10-20) ### Bug Fixes * **auth:** recover after synchronous refresh startup failure ([openai#1246](openai#1246)) ([efe5b95](openai@efe5b95)) ### Chores * **api:** clarify project API key update requirements ([openai#1244](openai#1244)) ([1e54d93](openai@1e54d93)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: openai-sdks[bot] <284451331+openai-sdks[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Record that project API-key updates require scopes, an expiration, or both using required-only
anyOf.The diff updates the transformed OpenAPI schema, generation metadata, and shared Castiron reporting helpers, and constructs a WebSocket test fixture before its timed concurrency scenario. Published Java runtime and source/binary compatibility are preserved.
Validation: generated ownership verification and the trusted public-main custom-code budget check pass (2,025 / 3,000 lines). Two independent review rounds are clean. Internal current-head CI and the separate OkTest run passed; that candidate was approved. Public CI is running.