Skip to content

fix(release): drop redundant version from homebrew formula template - #178

Merged
fullstackjam merged 1 commit into
mainfrom
cursor/drop-redundant-homebrew-version-582e
Nov 3, 2026
Merged

fullstackjam merged 1 commit into
mainfrom
cursor/drop-redundant-homebrew-version-582e

Conversation

@fullstackjam

Copy link
Copy Markdown
Member

What does this PR do?

Drops the explicit version stanza from the Homebrew formula written by the release workflow.

Why?

brew audit on openbootdotdev/homebrew-tap fails with Stable: version 1.0.6 is redundant with version scanned from URL. The download URL already contains vVERSION_PLACEHOLDER, and Homebrew scans the version from that URL. The formula test still calls version.to_s.

Testing

  • go vet ./... passes
  • Relevant tests added or updated
  • Tested locally (./openboot install --dry-run or similar)

Rendered the heredoc the workflow writes (version 1.0.6, current release checksums) and ran it as openbootdotdev/tap/openboot:

  • Without the version line: brew style reports no offenses and brew audit exits 0.
  • With version "1.0.6" restored: brew audit reports Stable: version 1.0.6 is redundant with version scanned from URL.

The vVERSION_PLACEHOLDER URLs and the sed replacement are unchanged.

Cross-repo checklist

  • Does this need a docs/content update in openboot.dev?
  • Does this change the CLI ↔ server API contract? (update openboot-contract first)

Notes for reviewer

The live tap formula still has the redundant version line until the next stable release regenerates it. This change only updates the template in update-homebrew-tap.

Open in Web Open in Cursor 

Homebrew already scans 1.0.6 from the release URL, so the explicit
version stanza fails brew audit as redundant. version.to_s in the
formula test still works from that scan.

Co-authored-by: fullstackjam <fullstackjam@users.noreply.github.com>
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-11-03T07:38:36.896688Z
We couldn’t complete this review. Comment @codex review to try again.
de8b069 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@github-actions github-actions Bot added the ci CI/CD changes label Nov 3, 2026
@fullstackjam
fullstackjam merged commit d58cc25 into main Nov 3, 2026
13 checks passed
@fullstackjam
fullstackjam deleted the cursor/drop-redundant-homebrew-version-582e branch November 3, 2026 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci CI/CD changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants