Repository navigation
fix(release): drop redundant version from homebrew formula template - #178
Merged
Merged
Conversation
Homebrew already scans 1.0.6 from the release URL, so the explicit version stanza fails brew audit as redundant. version.to_s in the formula test still works from that scan. Co-authored-by: fullstackjam <fullstackjam@users.noreply.github.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Drops the explicit
versionstanza from the Homebrew formula written by the release workflow.Why?
brew auditonopenbootdotdev/homebrew-tapfails withStable: version 1.0.6 is redundant with version scanned from URL. The download URL already containsvVERSION_PLACEHOLDER, and Homebrew scans the version from that URL. The formula test still callsversion.to_s.Testing
go vet ./...passes./openboot install --dry-runor similar)Rendered the heredoc the workflow writes (version
1.0.6, current release checksums) and ran it asopenbootdotdev/tap/openboot:versionline:brew stylereports no offenses andbrew auditexits 0.version "1.0.6"restored:brew auditreportsStable: version 1.0.6 is redundant with version scanned from URL.The
vVERSION_PLACEHOLDERURLs and thesedreplacement are unchanged.Cross-repo checklist
openboot.dev?openboot-contractfirst)Notes for reviewer
The live tap formula still has the redundant
versionline until the next stable release regenerates it. This change only updates the template inupdate-homebrew-tap.