Repository navigation
fix(mapper): own package-less nested TypeScript sources - #246
Merged
Merged
Conversation
Contributor
|
🦞👀 Pull request received. I will update this pull request when review starts. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #243.
Package-less sources such as
packages/core/governance/types.tswere missed because project discovery and source grouping only looked in conventional source directories. Discover these package roots from nested source evidence, then fill remaining ownership gaps after the existing mappers finish. Each newly covered file belongs to one bounded source group; existing owners, explicit package/project boundaries, workspace exclusions, configured exclusions, generated paths, and symlinks retain their behavior.Adds the reporter's synthetic reproduction and regressions for repositories without workspace metadata, deterministic remapping, bounded groups, nested explicit projects, existing owners, excludes, and symlinks. The new tests fail on v0.8.3 and pass with this fix. Updates feature-mapping documentation and the changelog, with thanks to @ptahdunbar for the report.
Validation: all 39 mapper/regression tests; typecheck; lint; formatting; build; package smoke. Independent Codex autoreview is clean through P2 after fixing nested-manifest boundary findings. Full-suite and Node 22/24/26 validation also run in PR CI.
Prepares patch release 0.8.4 with a dated changelog, release highlight, and an empty 0.8.5 Unreleased section. Release metadata independently reviewed through P2; publication follows the signed-tag release pipeline after merge.