Skip to content

graph: expose lockInfo on driveItems - #3444

Merged
butonic merged 2 commits into
mainfrom
feat/driveitem-lock
Sep 4, 2026
Merged

graph: expose lockInfo on driveItems#3444
butonic merged 2 commits into
mainfrom
feat/driveitem-lock

Conversation

@dschmidt

@dschmidt dschmidt commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Stacked on #3438 (shareTypes), implements opencloud-eu/libre-graph-api#59.

driveItems carry lockInfo while the item is locked for writing: lockType, createdDateTime, expirationDateTime, owners and @libre.graph.appName for app locks (WOPI), which MS Graph does not model. Everything is read off the CS3 lock the storage provider already reports with the item, so this needs no extra round-trip and no $select.

WebDAV renders the same state as d:lockdiscovery, but only in mangled form: the app name is folded into the d:owner string ("user via app") and the expiration becomes a relative d:timeout. The facet reports the four values directly.

Only exclusive locks are reported, that is all OpenCloud issues, matching the spec enum.

The spec PR has landed, so the SDK is bumped to libre-graph-api-go@45af3945a067, which carries LockInfo and the lockInfo facet. The bump also brings $expand on the driveItem and root endpoints and DriveRecipient.email, both additive.

@codacy-production

codacy-production Bot commented Sep 1, 2026

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 6 complexity

Metric Results
Complexity 6

View in Codacy

🟢 Coverage 100.00% diff coverage · +0.04% coverage variation

Metric Results
Coverage variation +0.04% coverage variation (-1.00%)
Diff coverage 100.00% diff coverage

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (addb328) 88294 20719 23.47%
Head commit (9a769b8) 88320 (+26) 20757 (+38) 23.50% (+0.04%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#3444) 26 26 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@dschmidt
dschmidt force-pushed the feat/driveitem-lock branch from 7885021 to da21977 Compare September 1, 2026 15:26
@dschmidt
dschmidt requested a review from butonic September 1, 2026 15:27
@butonic
butonic force-pushed the feat/driveitem-lock branch from da21977 to 5f98961 Compare September 2, 2026 22:03
@dschmidt
dschmidt force-pushed the feat/driveitem-lock branch from 5f98961 to 2f7ec2d Compare September 2, 2026 23:38
@dschmidt
dschmidt force-pushed the feat/driveitem-lock branch from 2f7ec2d to a834a2b Compare September 3, 2026 01:52
@dschmidt
dschmidt force-pushed the feat/driveitem-lock branch 2 times, most recently from 62df27d to 5964d02 Compare September 3, 2026 14:59
Base automatically changed from feat/driveitem-share-types to main September 3, 2026 15:52
@dschmidt
dschmidt force-pushed the feat/driveitem-lock branch from 5964d02 to bafbc88 Compare September 3, 2026 15:52
@dschmidt
dschmidt marked this pull request as ready for review September 3, 2026 15:52
@butonic
butonic merged commit 2ce9fae into main Sep 4, 2026
66 of 67 checks passed
@butonic
butonic deleted the feat/driveitem-lock branch September 4, 2026 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants