Repository navigation
fix(registry): apply transformInfo to ~preview JSON - #1607
Merged
Merged
Conversation
The ~preview route returned the raw package.json when JSON was requested, so anything hidden by discovery.transformInfo on ~info was still reachable there, even with discovery.api disabled. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #1606.
GET /:name[/:version]/~previewwith a JSONAcceptheader returned the raw package.json, bypassingdiscovery.transformInfoand ignoringdiscovery.api, so fields hidden from~info(e.g.owners,author) were still reachable there.discovery.transformInfoon the~previewJSON response, the same way as~info:requestVersionis added after the transform, and throwing/rejecting/non-object returns respond with a 500 (TRANSFORM_INFO_FAILED), never the raw package.json.~previewJSON whendiscovery.apiis enabled; otherwise respond401withDISCOVERY_API_DISABLED. Behaviour change for registries withapi: false, which previously still exposed it.name,versionandoc.files.imports), but it no longer throws when the info has nooc, which can happen when the preview comes from a fallback registry whose transform strips it.Test plan
~previewJSON: transformed output withrequestVersion, 500 on transform failure, 401 whendiscovery.apiis disabledocnpm run build(lint + tsc) and fulloctest suite (1209 passing)Generated with Devin