Repository navigation
Load fake Catalog Pathways into event_sink.catalog_pathway - #286
Conversation
|
Thanks for the pull request, @felipemontoya! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #286 +/- ##
==========================================
+ Coverage 89.90% 90.26% +0.35%
==========================================
Files 36 36
Lines 2843 2988 +145
Branches 307 322 +15
==========================================
+ Hits 2556 2697 +141
Misses 260 260
- Partials 27 31 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
4036698 to
b37bf5c
Compare
|
One small thing then I can merge and release. This should be a |
b37bf5c to
8dbf135
Compare
|
@bmtcril I squashed the commits and did the fix on the conventional commit |
Requires v2.2.0 from the platform-plugin-aspects
Head branch was pushed to by a user without write access
8dbf135 to
6fb1dfd
Compare
Generates fake Catalog Pathways and writes them to
event_sink.catalog_pathwayfrom every backend (ClickHouse, Ralph, Vector, chdb/S3, CSV).
Categories (Master's Degree, Annual Training, Professional Certificate), so
each org gets pathways of different categories.
num_catalog_pathways(default 6, set to 0 to disable) andfirst_catalog_pathway_id(default 100001, kept high so fake ids don't collidewith real pathways dumped by the LMS).
catalog_pathways.csv.gz.default_config.yamldocument the new keys.Requires the tutor-contrib-aspects migration
0042_event_sink_pathways,which creates the table. On older Aspects installs, set
num_catalog_pathways: 0.Tests: generator tests cover defaults, the id offset, disabling, and the
org/category spread for 1, 2, 3 and 5 orgs. The CSV backend test checks the
pathway row count.