OCPBUGS-105398: chore: remove AzureWorkloadIdentity feature gate

[damdo]

Summary

• Remove the AzureWorkloadIdentity feature gate from features/features.go — it has been enabled by default across all profiles and feature sets and is no longer needed
• Regenerate payload feature gate manifests (8 files) to reflect the removal

Test plan

• make test-unit passes (including TestOKDHasAllDefaultFeatureGates)
• hack/verify-payload-featuregates.sh passes
• No remaining references to AzureWorkloadIdentity feature gate registration in the codebase

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci]

Hello @damdo! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: e720d8af-ae0f-4247-b2e2-ec069afdf696

📥 Commits

Reviewing files that changed from the base of the PR and between c7d4aa1 and 80a61bd.

📒 Files selected for processing (10)

• features.md
• features/features.go
• payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-DevPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-TechPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-DevPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-TechPreviewNoUpgrade.yaml

💤 Files with no reviewable changes (10)

• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-DevPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-DevPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-TechPreviewNoUpgrade.yaml
• features/features.go
• payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-TechPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml
• features.md

Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review.

---

📝 Walkthrough

Walkthrough

The change removes the FeatureGateAzureWorkloadIdentity registration and its associated metadata and profiles. It also removes AzureWorkloadIdentity from enabled feature-gate lists in HyperShift and self-managed HA manifests for Default, DevPreviewNoUpgrade, OKD, and TechPreviewNoUpgrade configurations.

Merge Risk: ⚪ Minimal · up to 80a61

This PR removes an obsolete feature gate and updates its generated manifests and documentation; no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PASS: The pull request changes only feature-gate declarations, documentation, and YAML manifests. The diff contains no added or modified test files and no Ginkgo title calls (It, Describe, `Contex…
Test Structure And Quality	✅ Passed	PASS: The pull request changes only feature metadata, the Go feature-gate registration, and eight YAML manifests. The diff against origin/master contains no test files, Ginkgo blocks, cluster operatio…
Microshift Test Compatibility	✅ Passed	PASS: The pull request adds no Ginkgo e2e tests. The verified commit changes only feature metadata and eight YAML manifests, with 33 deletions and no added lines. Therefore, the MicroShift test compat…
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PASS: The pull request changes only feature documentation, feature-gate registration, and eight feature-gate manifests. The exact diff contains no new Ginkgo or e2e tests, so the SNO multi-node compat…
Topology-Aware Scheduling Compatibility	✅ Passed	PASS — The pull request only removes the AzureWorkloadIdentity registration, documentation row, and feature-gate list entries. The exact diff does not add or modify deployments, controllers, operato…
Ote Binary Stdout Contract	✅ Passed	PASS: The pull request changes only feature-gate registration data and generated YAML/Markdown. All changes are deletions. No main, init, TestMain, or Ginkgo suite setup code changed. The removed init…
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PASS — The pull request only removes a feature-gate declaration, documentation, and manifest entries. The exact diff adds no Ginkgo tests or test code, so it introduces no IPv4 assumptions or external…
No-Weak-Crypto	✅ Passed	PASS. The pull request only deletes the AzureWorkloadIdentity feature-gate registration, its documentation row, and eight manifest entries. The exact diff contains no MD5, SHA1, DES, RC4, Blowfish, EC…
Container-Privileges	✅ Passed	PASS: The pull request contains only deletions from feature metadata and FeatureGate status manifests. The diff has no added lines and no changes to container or Kubernetes security fields. The change…
No-Sensitive-Data-In-Logs	✅ Passed	PASS. The pull request changes only feature metadata and feature-gate manifests. The verified diff contains 33 deletions and no added lines. It removes the AzureWorkloadIdentity registration and manif…
Title check	✅ Passed	The title clearly identifies the primary change: removal of the AzureWorkloadIdentity feature gate.
Description check	✅ Passed	The description directly explains the feature-gate removal, manifest regeneration, and reported verification steps.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.

Full details: Stable And Deterministic Test Names

Explanation

PASS: The pull request changes only feature-gate declarations, documentation, and YAML manifests. The diff contains no added or modified test files and no Ginkgo title calls (It, Describe, Context, or When). The remaining AzureWorkloadIdentity references are unchanged legacy lists and a static test fixture, not test titles. Therefore, the pull request introduces no unstable or overly-specific test name.

Full details: Test Structure And Quality

Explanation

PASS: The pull request changes only feature metadata, the Go feature-gate registration, and eight YAML manifests. The diff against origin/master contains no test files, Ginkgo blocks, cluster operations, Eventually/Consistently calls, or assertions. Therefore the Ginkgo test quality requirements are not applicable.

Full details: Microshift Test Compatibility

Explanation

PASS: The pull request adds no Ginkgo e2e tests. The verified commit changes only feature metadata and eight YAML manifests, with 33 deletions and no added lines. Therefore, the MicroShift test compatibility check is not applicable.

Full details: Single Node Openshift (Sno) Test Compatibility

Explanation

PASS: The pull request changes only feature documentation, feature-gate registration, and eight feature-gate manifests. The exact diff contains no new Ginkgo or e2e tests, so the SNO multi-node compatibility check does not apply.

Full details: Topology-Aware Scheduling Compatibility

Explanation

PASS — The pull request only removes the AzureWorkloadIdentity registration, documentation row, and feature-gate list entries. The exact diff does not add or modify deployments, controllers, operators, or scheduling fields such as affinity, topology spread, replicas, node selectors, tolerations, or PDBs. Therefore, it introduces no topology-unaware scheduling constraint.

Full details: Ote Binary Stdout Contract

Explanation

PASS: The pull request changes only feature-gate registration data and generated YAML/Markdown. All changes are deletions. No main, init, TestMain, or Ginkgo suite setup code changed. The removed initializer called registration methods that only updated the in-memory feature-gate map; it did not write to stdout or log. No changed code introduces a process-level stdout write.

Full details: Ipv6 And Disconnected Network Test Compatibility

Explanation

PASS — The pull request only removes a feature-gate declaration, documentation, and manifest entries. The exact diff adds no Ginkgo tests or test code, so it introduces no IPv4 assumptions or external connectivity requirements.

Full details: No-Weak-Crypto

Explanation

PASS. The pull request only deletes the AzureWorkloadIdentity feature-gate registration, its documentation row, and eight manifest entries. The exact diff contains no MD5, SHA1, DES, RC4, Blowfish, ECB, custom crypto, or non-constant-time secret comparison changes. The remaining AzureWorkloadIdentity references are unchanged legacy compatibility entries.

Full details: Container-Privileges

Explanation

PASS: The pull request contains only deletions from feature metadata and FeatureGate status manifests. The diff has no added lines and no changes to container or Kubernetes security fields. The changed manifests are kind: FeatureGate resources, and searches of all changed files found no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or allowPrivilegeEscalation entries.

Full details: No-Sensitive-Data-In-Logs

Explanation

PASS. The pull request changes only feature metadata and feature-gate manifests. The verified diff contains 33 deletions and no added lines. It removes the AzureWorkloadIdentity registration and manifest entries. It adds no logging calls and no passwords, tokens, API keys, PII, hostnames, or customer data to logs.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign everettraven for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@damdo: This pull request references Jira Issue OCPBUGS-105398, which is invalid:

• expected the bug to target the "5.1.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

• Remove the AzureWorkloadIdentity feature gate from features/features.go — it has been enabled by default across all profiles and feature sets and is no longer needed
• Regenerate payload feature gate manifests (8 files) to reflect the removal

Test plan

• make test-unit passes (including TestOKDHasAllDefaultFeatureGates)
• hack/verify-payload-featuregates.sh passes
• No remaining references to AzureWorkloadIdentity feature gate registration in the codebase

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[damdo]

/hold

For openshift/machine-api-provider-azure#207 to merge first

[damdo]

/pipeline auto

[openshift-merge-bot]

Pipeline controller notification

The pipeline-auto label has been added to this PR. Second-stage tests will be triggered automatically when all first-stage tests pass.

[openshift-merge-bot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change
/test minor-e2e-upgrade-minor

[openshift-merge-bot]

Tests from second stage were triggered manually. Pipeline can be controlled only manually, until HEAD changes. Use command to trigger second stage.

[openshift-ci]

@damdo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-upgrade	80a61bd	link	true	/test e2e-upgrade
ci/prow/e2e-aws-ovn-techpreview	80a61bd	link	true	/test e2e-aws-ovn-techpreview
ci/prow/e2e-aws-ovn-hypershift	80a61bd	link	true	/test e2e-aws-ovn-hypershift
ci/prow/e2e-upgrade-out-of-change	80a61bd	link	true	/test e2e-upgrade-out-of-change
ci/prow/e2e-aws-ovn-hypershift-conformance	80a61bd	link	true	/test e2e-aws-ovn-hypershift-conformance
ci/prow/e2e-azure	80a61bd	link	true	/test e2e-azure
ci/prow/e2e-aws-serial-techpreview-2of2	80a61bd	link	true	/test e2e-aws-serial-techpreview-2of2
ci/prow/e2e-aws-serial-1of2	80a61bd	link	true	/test e2e-aws-serial-1of2
ci/prow/e2e-aws-ovn	80a61bd	link	true	/test e2e-aws-ovn
ci/prow/e2e-aws-serial-techpreview-1of2	80a61bd	link	true	/test e2e-aws-serial-techpreview-1of2
ci/prow/minor-e2e-upgrade-minor	80a61bd	link	true	/test minor-e2e-upgrade-minor
ci/prow/e2e-gcp	80a61bd	link	true	/test e2e-gcp
ci/prow/e2e-aws-serial-2of2	80a61bd	link	true	/test e2e-aws-serial-2of2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.