Repository navigation
refactor: standardize build feature macros and cleanup storage headers - #536
Merged
Merged
Conversation
hummeltech
commented
Oct 31, 2026
hummeltech
commented
Collaborator
- Move context and tile cache struct definitions for ro_composite and ro_http_proxy into public header files to enable internal test visibility.
- Standardize compile-time feature checks across storage backends and unit tests, replacing WANT_STORE_COMPOSITE with HAVE_CAIRO.
- Clean up unused/duplicate include directives across source files and unit tests, and add missing copyright headers to store.c and sys_utils.c.
- Move context and tile cache struct definitions for ro_composite and ro_http_proxy into public header files to enable internal test visibility. - Standardize compile-time feature checks across storage backends and unit tests, replacing WANT_STORE_COMPOSITE with HAVE_CAIRO. - Clean up unused/duplicate include directives across source files and unit tests, and add missing copyright headers to store.c and sys_utils.c.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| struct stat_info st_stat; | ||
| char * tile; | ||
| int x, y, z; | ||
| char xmlname[XMLCONFIG_MAX]; |
|
|
||
| struct ro_composite_ctx { | ||
| struct storage_backend * store_primary; | ||
| char xmlconfig_primary[XMLCONFIG_MAX]; |
| struct storage_backend * store_primary; | ||
| char xmlconfig_primary[XMLCONFIG_MAX]; | ||
| struct storage_backend * store_secondary; | ||
| char xmlconfig_secondary[XMLCONFIG_MAX]; |
| struct stat_info st_stat; | ||
| char * tile; | ||
| int x, y, z; | ||
| char xmlname[XMLCONFIG_MAX]; |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #536 +/- ##
==========================================
+ Coverage 81.54% 89.58% +8.04%
==========================================
Files 24 24
Lines 5645 5463 -182
==========================================
+ Hits 4603 4894 +291
+ Misses 1042 569 -473 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.