Repository navigation
test(xtest): DSPX-1561 cover assertion hash input, strict manifest parsing, and binding forms - #707
Draft
dmihalcik-virtru wants to merge 1 commit into
Draft
dmihalcik-virtru wants to merge 1 commit into
dmihalcik-virtru wants to merge 1 commit into
Conversation
…rsing, and binding forms Adds the Phase 0 feature gate assertion_hash_raw, force-only like assertion_header_key_pinning; branch builds run the cases with XT_FORCE_SUPPORTS=assertion_header_key_pinning,assertion_hash_raw. test_assertion_verification.py gains cases that check how each SDK reads assertions built into TDFs it wrote: - the hash over the assertion as received, including unmodelled members and an object-valued statement value; - strict manifest parsing, including assertions from the DSPX-5520 vectors and case variants across the manifest on real TDFs (Payload alongside payload, URL in a key access object, SchemaVersion), with a positive control for the IsStreamable spelling written by older Java SDKs; - spec Section 5.1 binding forms. Every rejection is matched by its reported reason and has a positive control. test_assertion_gmac_limitation.py documents a known, unfixed limitation of GMAC segment integrity for holders of the payload key (spec Section 10.7). It needs the local KAS key and skips without it. It runs in the standard and focused xtest steps. Signed-off-by: Dave Mihalcik <dmihalcik@virtru.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This was referenced Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Split out of #702 (draft; the complete change). Stacked on #706.
test_assertion_verification.pygains cases, on TDFs each SDK wrote, for:Payloadalongsidepayload,URLin a key access object,SchemaVersion);IsStreamablespelling that older Java SDKs wrote.Every rejection is matched by its reported reason and has a positive control.
test_assertion_gmac_limitation.pydocuments a known limitation of GMAC segment integrity (spec Section 10.7). It needs the local KAS key and skips without it.assertion_hash_raw, force-only likeassertion_header_key_pinning.xtest.ymlruns both modules in the standard and focused steps.Testing
cd xtest && uv run ruff check . && uv run ruff format --check . && uv run pyright, plus the offline unit tests fromcheck.yml.XT_FORCE_SUPPORTS=assertion_header_key_pinning,assertion_hash_raw uv run pytest test_assertion_verification.py test_assertion_gmac_limitation.py --sdks "go java js"against the SDK branches.Related pull requests