[#819] ThirdParty 모듈로 외부 라이브러리 의존성을 통합한다 - #820
Merged
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4aa1f9c4dc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 연관된 이슈
🎯 의도
외부 라이브러리의 package 선언과 product dependency를
ThirdParty모듈로 통합해 전체 의존성 목록과 링크 구조를 한곳에서 관리함.📝 작업 내용
📌 요약
Libraries/ThirdPartyframework target 추가GoogleSignIn,Nexa,ComposableArchitecture,OrderedCollections의존성 이동Infra,PresentationShared,App이ThirdParty를 통해 외부 framework를 링크하도록 변경DevLogPackageshelper 제거 및 의존성 그래프 갱신🔍 상세
ThirdParty는 외부 package 선언과 product 링크만 소유함Infra의 Firebase,GoogleSignIn,Nexa직접 package dependency를 제거함PresentationShared의ComposableArchitecture,OrderedCollections직접 package dependency를 제거함App에ThirdPartyproject dependency를 추가함DevLogPackages.defaultPackages참조를 제거하고DevLogScripts를Project+Scripts.swift로 분리함ThirdParty가 포함된 현재 module dependency graph를docs/graph.png에 반영함