AO3-7366 AO3-7367 add username, skin type to users' skin page titles

[snuli375]

Pull Request Checklist

• Have you read the contributing guidelines?
• Have you read "How to write the perfect pull request"?
• Have you added tests for any changed functionality?
• Have you added the Jira issue number
  as the first thing in your pull request title (e.g. AO3-1234 Fix thing)
• Do you have fewer than 5 pull requests already open? If not, please wait
  until they are reviewed and merged before creating new pull requests.
• I acknowledge that submitting code created or modified with the help of AI is a bannable offense.

Issue

https://otwarchive.atlassian.net/browse/AO3-7366 (site skins)
https://otwarchive.atlassian.net/browse/AO3-7367 (work skins)

Purpose

What does this PR do?

• adds translatable strings for users' site skin and work skin pages (with username prepended)
• implement use of new translatable strings

Proof of (Local) Testing

Images

Skin Creation Page

Public Skins

User Skins

Testing Instructions

How can the Archive's QA team verify that this is working as you intended?

1. login to an account (ex. testuser, or replace testuser below with your username)
2. visit /users/testuser/skins?skin_type=Site
   a. confirm page title (in tab) displays "testuser - Site Skins | Archive Name"
3. visit /users/testuser/skins?skin_type=WorkSkin
   a. confirm page title (in tab) displays "testuser - Work Skins | Archive Name"
4. visit /skins?skin_type=Site
   a. confirm page title (in tab) displays "Public Site Skins | Archive Name"
5. visit /skins?skin_type=WorkSkin
   a. confirm page title (in tab) displays "Public Work Skins | Archive Name"

Credit

What name and pronouns should we use to credit you in the Archive of Our Own's Release Notes?
snuli375 they/them

If you have a Jira account, please include the same name in the "Full name"
field on your Jira profile, so we can assign you the issues you're working on.

Please note that if you do not fill in this section, we will use your GitHub account name and
they/them pronouns.

[ASalbenblatt]

I'm curious, is there a specific reason you wrote both an RSpec and Cucumber test for the same functionality?

[snuli375]

I'm curious, is there a specific reason you wrote both an RSpec and Cucumber test for the same functionality?

i saw both listed in the wiki and assumed i needed both 😅

should i just add one or the other, @ASalbenblatt?

[ASalbenblatt]

Yea, they're usually used for testing different things, in this case since it can be covered by a cucumber test and it isn't testing the functionality of hidden ruby code or something, I would just keep the cucumber test and remove the RSpec one

Cucumber tests are easier to read and update so I think they're generally preferred whenever it's something visible to a user (as that's most of what cucumber can look at)

[ASalbenblatt]

Other than that though, this looks great! I sadly don't have write access so someone else will also need to review this for it to be considered reviewed, but it looks good to me.

(I will note, you don't have to include proof that you tested it if you don't want to, but kudos for including it anyway)

[sarken]

Hi, snuli375!

Thank you so much for this pull request. I've gone ahead and marked it ready to merge based on @ASalbenblatt's review.

Jira has been unreliable about showing us new accounts in the admin panel lately, so I'm unfortunately having trouble finding your account to update its permissions. If you could reply here or send an email to otw-coders@transformativeworks.org with the email address associated with your account, we should be able to get your permissions set up.

Thanks again for contributing! If you have any questions, you can contact us at the same email address listed above.