Repository navigation
ci: run the acceptance tests with Redis and include @local_storage - #744
Merged
Merged
Conversation
Redis is the recommended setup for caching and file locking. Without it ownCloud locks in the database, and uploads into a local storage mount created during a test failed with 423 Locked, so @local_storage was excluded. With Redis, cliLocalStorage/showBackendsForMount passes 20 of 20 scenarios, against 2 of 20 without it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Thomas Müller <323649642+oc-tmueller@users.noreply.github.com>
Stop with a clear message when the Redis container does not answer, save its log with the others, and describe the 423 Locked failures as observed rather than as an established cause. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Thomas Müller <323649642+oc-tmueller@users.noreply.github.com>
With Redis the WebDAV external storage CLI scenarios, the API local storage sharing scenarios, apiMain/external-storage.feature:65 and apiTrashbinRestore/trashbinRestore.feature:171 pass, so they come off the smoke and full lists. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Thomas Müller <323649642+oc-tmueller@users.noreply.github.com>
oc-tmueller
marked this pull request as ready for review
October 26, 2026 20:54
Member
Author
|
@phil-davis @jvillafanez please review |
phil-davis
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows up on @jvillafanez's comment in #738 (#738 (comment)): the acceptance setup now includes Redis, as recommended for production.
Why it matters here. Without Redis, ownCloud locks files in the database, the image's default. With that, uploads into a local storage mount created during a test failed with
423 Locked. Which scenarios failed changed from run to run, so #738 had to exclude@local_storage. The same feature run locally againstowncloud/server:11.0.1:OWNCLOUD_REDIS_ENABLED=true)Changes
run-part.sh:redis:7next to MariaDB and waits forPONG.OWNCLOUD_REDIS_ENABLED=trueandOWNCLOUD_REDIS_HOSTon the server.redis.logwith the other logs.acceptance.yml:~@local_storageis no longer excluded.Draft until the expected-failures lists match Redis. This PR's smoke run checks the smoke lists. A manual full run (
workflow_dispatchon this branch, which doesn't publish) checks the full lists and the API@local_storagescenarios. Listed failures that now pass are removed here.Open for review
redis:7andmariadb:10.11are floating tags that Renovate doesn't track in this script.🤖 Generated with Claude Code