Repository navigation
ci: keep the Docker Hub link check off core's feature links - #745
Merged
Merged
Conversation
The Docker Hub description job runs markdown-link-check over every Markdown file. The expected-failures headers had a made-up example link, and core's lint-expected-failures.sh requires each entry to link to core's master branch, where 10.16-only features such as cliDbConversion/dbConversion.feature do not exist. Put the example in inline code, mark the 10.16-only entry, and skip core feature links in mlc_config.json. The lint only checks the form of those links; what catches a stale entry is run.sh's unexpected-pass check. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Thomas Müller <323649642+oc-tmueller@users.noreply.github.com>
phil-davis
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #738,
update-docker-hub-descriptionhas failed on every master push, so the Docker Hub description has not been updated since then. The acceptance tests and the builds passed, and the images were published.That job runs
markdown-link-checkover every Markdown file, and the expected-failures lists had dead links:apiSuite/file.feature) in each list's header;cliDbConversion/dbConversion.feature:30in the 10.16.6 lists. core'slint-expected-failures.shrequires every entry to link to core'smaster, and that feature only exists up to 10.16 (404 on master, 200 atv10.16.6).Changes
mlc_config.jsonskips links to core's acceptance feature files. The shared action reads it from the repo root by default (config-file: mlc_config.json). Stale entries are still caught by run.sh's unexpected-pass check; core's lint only checks the form of the link.agents.mdlists the new file.Verified locally with
markdown-link-checkover every Markdown file: clean with the config. Without the config, exactly thedbConversion404 is left, so the config is what removes it. core's lint and editorconfig also pass.The Docker Hub job only runs on master, so this PR's CI can't show the fix. The first master run after merge will. The ignore pattern applies to the whole repo, not just
.github/acceptance, becausemarkdown-link-checkhas no per-path ignore.🤖 Generated with Claude Code