Skip to content

Check API version before deploying to dogfood - #3449

Merged
david-crespo merged 1 commit into
mainfrom
check-api-version-dogfood
Nov 20, 2026
Merged

david-crespo merged 1 commit into
mainfrom
check-api-version-dogfood

Conversation

@david-crespo

Copy link
Copy Markdown
Collaborator

If we accidentally yolo a version of the console to dogfood that has a too-new API client, it won't work at all. Someone how it never occurred to me before we can just check this at upload time. With oxidecomputer/omicron#10250 we'll have an endpoint we can call to find the current version deployed, but in the meantime we can get it (without auth) through binary search, making requests against the API with various api-version values and seeing which are rejected with a version error.

If the check fails, we get output like this:

Resolved fe921de7 to fe921de77014b066d8d211d104d1abb648c725f8
Checking which API versions dogfood accepts...
Dogfood API version: 2026110500.0.0
Console API version: 2026111000.0.0

Error: dogfood would reject API requests from this console build. Pick a commit with app/api/__generated__/API_VERSION at or below dogfood's.

@vercel

vercel Bot commented Nov 20, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
console Ready Ready Preview Nov 20, 2026 12:58am UTC

Request Review

@david-crespo
david-crespo enabled auto-merge (squash) November 20, 2026 00:59
@david-crespo
david-crespo enabled auto-merge (squash) November 20, 2026 01:01
@david-crespo
david-crespo merged commit 0f508ce into main Nov 20, 2026
9 checks passed
@david-crespo
david-crespo deleted the check-api-version-dogfood branch November 20, 2026 01:14

This branch was successfully deployed

1 active deployment
Preview — 333d984d Deployed Nov 20, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant