Repository navigation
Check API version before deploying to dogfood - #3449
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
david-crespo
enabled auto-merge (squash)
November 20, 2026 00:59
david-crespo
disabled auto-merge
November 20, 2026 00:59
david-crespo
enabled auto-merge (squash)
November 20, 2026 01:01
This was referenced Nov 20, 2026
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Nov 21, 2026
oxidecomputer/console@fe921de...55bc9f3 * [55bc9f3f](oxidecomputer/console@55bc9f3f) oxidecomputer/console#3427 * [37403197](oxidecomputer/console@37403197) oxidecomputer/console#3361 * [5f7377ba](oxidecomputer/console@5f7377ba) oxidecomputer/console#3416 * [0f508ce5](oxidecomputer/console@0f508ce5) oxidecomputer/console#3449
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we accidentally yolo a version of the console to dogfood that has a too-new API client, it won't work at all. Someone how it never occurred to me before we can just check this at upload time. With oxidecomputer/omicron#10250 we'll have an endpoint we can call to find the current version deployed, but in the meantime we can get it (without auth) through binary search, making requests against the API with various
api-versionvalues and seeing which are rejected with a version error.If the check fails, we get output like this: