Repository navigation
Fix link underlining in truncated cells - #3450
Open
charliepark wants to merge 4 commits into
Open
charliepark wants to merge 4 commits into
charliepark wants to merge 4 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After merging #3416, I noticed that the linked + truncated cells weren't showing the [Ralph Wiggum voice] "I'm a link" underline I expected them to.
Before:

It turns out that this was a side effect of the absolute positioning we were using in the cell. Absolutely positioned descendants don't inherit
text-decoration: underline. So even though the truncation itself was working, the interaction between the linking and the truncation gave it some trouble. By moving fromrelative>absolutetogrid>col-start-1 row-start-1we get both the truncation and the text decoration.I also noted something I should have seen earlier, that the table was sometimes forced into scrolling, so I've made the ID column a bit narrower, while still preserving enough of the characters before and after the ellipsis that they are distinguishable. This uses the same width (
32) as theshortCellIdcomponent.After:
