Skip to content

Fix link underlining in truncated cells - #3450

Open
charliepark wants to merge 4 commits into
mainfrom
better-truncated-links
Open

charliepark wants to merge 4 commits into
mainfrom
better-truncated-links

Conversation

@charliepark

@charliepark charliepark commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

After merging #3416, I noticed that the linked + truncated cells weren't showing the [Ralph Wiggum voice] "I'm a link" underline I expected them to.

Before:
Screenshot 2026-11-20 at 1 28 30 PM
It turns out that this was a side effect of the absolute positioning we were using in the cell. Absolutely positioned descendants don't inherit text-decoration: underline. So even though the truncation itself was working, the interaction between the linking and the truncation gave it some trouble. By moving from relative > absolute to grid > col-start-1 row-start-1 we get both the truncation and the text decoration.

I also noted something I should have seen earlier, that the table was sometimes forced into scrolling, so I've made the ID column a bit narrower, while still preserving enough of the characters before and after the ellipsis that they are distinguishable. This uses the same width (32) as the shortCellId component.

After:
Screenshot 2026-11-20 at 1 28 53 PM

@vercel

vercel Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
console Ready Ready Preview Nov 21, 2026 12:15am UTC

Request Review

This branch was successfully deployed

1 active deployment
Preview — 35f15ff3 Deployed Nov 21, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant