Skip to content

Make multicast test instance setup simpler + fix test bitrot - #11870

Open
iximeow wants to merge 1 commit into
mainfrom
ixi/instance-create-test-params-multicast
Open

iximeow wants to merge 1 commit into
mainfrom
ixi/instance-create-test-params-multicast

Conversation

@iximeow

@iximeow iximeow commented Nov 20, 2026 •

Copy link
Copy Markdown
Member

(this is a draft as I wait for CI to finish on #11858. this change is really just 4b2e6d1)

I'd initially missed a bunch of instances of us manually expanding InstanceCreate in #11858 because I grepped incompletely, but that turns out to have been kind of good: the multicast tests only run under a feature flag, so it seems we'd broken them through other changes in the last ten months anyhow. so, this change has become more of a "bring nexus/tests/integration_tests/multicast/ into the shiny more-legible future and fix other issues along the way".

I don't know much about Dendrite, if these have become runnable-by-default, if we should run these in CI, any of that. but now they build! and that seems better than before! we probably should at least cargo build --test --features multicast in a job somewhere to keep "it typechecks" levels of runnable.

both #11565 and a change I'll have up in a bit here add fields to InstanceCreate, which definitely would have made things worse, and with this change would not require any additional edits in multicast (or any other) integration tests 🙏

MulticastGroupJoinSpec, MulticastGroupMember,
};
use omicron_common::address::is_ssm_address;
use omicron_common::api::external::{

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved InstanceCpuCount to nexus_types::external_api back in June, so that's at least some bound on when these were last built..

@iximeow
iximeow force-pushed the ixi/instance-create-test-params-multicast branch from 4b2e6d1 to eeb7f39 Compare November 20, 2026 04:58
@iximeow
iximeow marked this pull request as ready for review November 20, 2026 04:58
@zeeshanlakhani

zeeshanlakhani commented Nov 20, 2026 •

Copy link
Copy Markdown
Collaborator

For posterity, #11788 runs the mcast integration test suite again (tied to work in Dendrite that's going through hardware testing atm). That's meant to go in soon! I'll run these though to test and post the result as part of my review @iximeow.

So, we probably don't need a separate CI build with that going in.

.with_hostname(&instance_name)
.with_user_data(&[])
.with_ssh_public_keys(None)
.with_multicast_groups(vec![])

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally since these tests look like it'd be nice to have an empty initial multicast group set I opted to make that explicit. my expectation is that after this is merged it would make sense to drop with_{ncpus,memory,hostname,user_data,ssh_public_keys} from basically every use outside the handful of tests that care about those specific parameters

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants