Skip to content

add MSRV check to CI - #938

Merged
ahl merged 2 commits into
oxidecomputer:mainfrom
danieleades:msrv
Nov 17, 2026
Merged

ahl merged 2 commits into
oxidecomputer:mainfrom
danieleades:msrv

Conversation

@danieleades

@danieleades danieleades commented Dec 20, 2025 •

Copy link
Copy Markdown
Contributor

Summary

  • declare Rust 1.88 as the workspace MSRV;
  • apply that declaration to all four published packages;
  • add an additive CI job that checks each published package at its declared MSRV;
  • enable Serde's derive feature for the build dependency exposed by --no-dev-deps.

This PR deliberately keeps rust-toolchain.toml, the existing build-and-test matrix and job name, and current action versions unchanged. The contributor-toolchain and broader stable/nightly CI policy is split into #1058.

Validation

cargo hack --workspace --exclude typify-test --exclude example-build --exclude example-macro --no-dev-deps --rust-version check
cargo +1.89.0 fmt --all -- --check
cargo +1.89.0 test --workspace --locked

All commands pass locally; the MSRV checks select Rust 1.88 from the declared package metadata.

@danieleades

Copy link
Copy Markdown
Contributor Author

@ahl is this of interest?

danieleades and others added 2 commits November 16, 2026 19:29
The msrv job builds and runs the suite on 1.97, the version typespace
requires, instead of a cargo-hack check at 1.88. Actions are pinned by
SHA, clippy and docs jobs deny warnings, and the existing job names stay
as they are so branch protection keeps matching.

@ahl ahl left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is of interest

@ahl
ahl merged commit fff0acf into oxidecomputer:main Nov 17, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants