Repository navigation
Conversation
A caret whose paragraph moved to another page is repaired first; a caret on a page out of view then scrolls it into view. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening a 50 MB Markdown file fails with
Maximum call stack size exceededbecause the importer passes all parsed paragraphs to onepush(...items)call. After resolving that, the resulting 21,112-page document exceeds the browser’s element-height limit, leaving its final pages unreachable.This PR fixes both:
The existing DOM rendering and visual editing path are retained, with no new runtime dependencies.
Regression coverage includes 150,000-paragraph Markdown and HTML inputs, a 150,000-line code block, and a document beyond the browser’s scroll-height limit whose final page is reached, searched, edited and saved. The original 50 MB fixture now loads completely, and its final marker is reachable and searchable.
Validation
mainand pass with this change.git diff --checkpassed.The browser checks cover the new regressions plus existing document editing, selection, page setup and comments.