Skip to content

Split Log Detective switches for Koji and Copr - #720

Open
jpodivin wants to merge 1 commit into
packit:mainfrom
jpodivin:new_ld
Open

jpodivin wants to merge 1 commit into
packit:mainfrom
jpodivin:new_ld

Conversation

@jpodivin

Copy link
Copy Markdown
Contributor

Preserve Koji analysis in staging and production and leave Copr analysis disabled. Document the coordinated configuration and image cutover.

Merge after
packit/packit-service#3213

Preserve Koji analysis in staging and production and leave Copr analysis disabled. Document the coordinated configuration and image cutover.

Signed-off-by: Jiri Podivin <jpodivin@redhat.com>
Assisted-by: Codex <noreply@openai.com>
@centosinfra-prod-github-app

Copy link
Copy Markdown
Contributor

@betulependule betulependule left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have no problem keeping the short documentation. It's better than having none and it can always be removed later.

The PR description mentions to merge this PR after the changes in packit-service. I believe it needs to be done the other way around. Staging Packit and internal Packit will be automatically re-deployed once packit/packit-service#3213 is merged -- with the old service config (we have a GitHub action which triggers this re-deployment when new commits are added to main).

If you first merge this PR, nothing gets deployed automatically right away, which should then give you time to merge packit/packit-service#3213, which would then lead to both staging and internal deployment being deployed with the proper service configs (with both log_detective_koji_enabled and log_detective_copr_enabled defined).

Though @mfocko can correct me if I'm missing something / am mistaken about the order. 👀

@jpodivin

Copy link
Copy Markdown
Contributor Author

LGTM. I have no problem keeping the short documentation. It's better than having none and it can always be removed later.

The PR description mentions to merge this PR after the changes in packit-service. I believe it needs to be done the other way around. Staging Packit and internal Packit will be automatically re-deployed once packit/packit-service#3213 is merged -- with the old service config (we have a GitHub action which triggers this re-deployment when new commits are added to main).

If you first merge this PR, nothing gets deployed automatically right away, which should then give you time to merge packit/packit-service#3213, which would then lead to both staging and internal deployment being deployed with the proper service configs (with both log_detective_koji_enabled and log_detective_copr_enabled defined).

Though @mfocko can correct me if I'm missing something / am mistaken about the order. 👀

Ok. I didn't know the order of deployment. If merge here doesn't trigger anything we can do it afterwards. We just need to make sure not to leave too long a gap, so that something else doesn't get merged in packit-service in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants