Repository navigation
Conversation
Preserve Koji analysis in staging and production and leave Copr analysis disabled. Document the coordinated configuration and image cutover. Signed-off-by: Jiri Podivin <jpodivin@redhat.com> Assisted-by: Codex <noreply@openai.com>
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 39s |
There was a problem hiding this comment.
LGTM. I have no problem keeping the short documentation. It's better than having none and it can always be removed later.
The PR description mentions to merge this PR after the changes in packit-service. I believe it needs to be done the other way around. Staging Packit and internal Packit will be automatically re-deployed once packit/packit-service#3213 is merged -- with the old service config (we have a GitHub action which triggers this re-deployment when new commits are added to main).
If you first merge this PR, nothing gets deployed automatically right away, which should then give you time to merge packit/packit-service#3213, which would then lead to both staging and internal deployment being deployed with the proper service configs (with both log_detective_koji_enabled and log_detective_copr_enabled defined).
Though @mfocko can correct me if I'm missing something / am mistaken about the order. 👀
Ok. I didn't know the order of deployment. If merge here doesn't trigger anything we can do it afterwards. We just need to make sure not to leave too long a gap, so that something else doesn't get merged in |
Preserve Koji analysis in staging and production and leave Copr analysis disabled. Document the coordinated configuration and image cutover.
Merge after
packit/packit-service#3213